From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 3/3] xen/arm: io: Shorten the name of the fields and clean up Date: Thu, 1 Oct 2015 13:41:43 +0100 Message-ID: <1443703303.11707.35.camel@citrix.com> References: <1443537881-6816-1-git-send-email-julien.grall@citrix.com> <1443537881-6816-4-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZhdBE-0000AK-GB for xen-devel@lists.xenproject.org; Thu, 01 Oct 2015 12:41:48 +0000 In-Reply-To: <1443537881-6816-4-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-29 at 15:44 +0100, Julien Grall wrote: > The field names in the IO emulation are really long and use repeatedly > the term handler which make some line cumbersome to read: > > mmio_handler->mmio_handler_ops->write_handler > > Also take the opportunity to do some clean up: > - Avoid "handler" vs "handle" in register_mmio_handler > - Use a local variable to initialize handler in > register_mmio_handler > - Add a comment explaining the dsb(ish) in register_mmio_handler > - Rename the structure io_handler into vmmio because the io_handler > is in fine handling multiple handlers and the name a the fields was > io_handlers. Also rename the field io_handlers to vmmio > - Rename the field mmio_handler_ops to ops because we are in the > structure mmio_handler to not need to repeat it > - Rename the field mmio_handlers to handlers because we are in the > vmmio structure > - Make it clear that register_mmio_ops is taking an ops and not an > handle > - Clean up local variable to help to understand the code > > Signed-off-by: Julien Grall > > --- > This is the last patch of the series so to make easy to backport the > previous patches to Xen 4.6 if necessary. > > Ian, I haven't kept your acked-by because I had to rebase after the > changes you requested on patch #1. No problem, for something like that I wouldn't have minded if you had kept it. In any case this version: Acked-by: Ian Campbell