xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST 4/8] ts-kernel-build: Refactor $archparams KernelImage handling
Date: Fri, 2 Oct 2015 10:26:14 +0100	[thread overview]
Message-ID: <1443777978-11119-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1443777956.11707.61.camel@citrix.com>

This is always arch/$karch/boot/$img. Store $img in %archparms and use
%arch_debian2linux to construct the full path as needed.

This makes the $archparams less verbose.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 ts-kernel-build | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ts-kernel-build b/ts-kernel-build
index 8443754..7240b5e 100755
--- a/ts-kernel-build
+++ b/ts-kernel-build
@@ -42,9 +42,9 @@ selectbuildhost(\@ARGV);
 builddirsprops();
 
 my $archparms = {
-    'armhf' => { DefConfig => 'multi_v7', KernelImage => 'arch/arm/boot/zImage' },
-    'i386'  => {                          KernelImage => 'arch/x86/boot/bzImage' },
-    'amd64' => {                          KernelImage => 'arch/x86/boot/bzImage' }
+    'armhf' => { DefConfig => 'multi_v7', Image => 'zImage' },
+    'i386'  => {                          Image => 'bzImage' },
+    'amd64' => {                          Image => 'bzImage' }
 };
 my $parms = $archparms->{ $r{arch} };
 
@@ -379,7 +379,9 @@ END
 
 sub kinstall () {
     my $kernfile= $r{kimagefile};
-    $kernfile= $parms->{KernelImage} if !defined $kernfile;
+    my $karch = $arch_debian2linux{$r{arch}};
+    $kernfile = "arch/$karch/boot/$parms->{Image}"
+	if !defined $kernfile;
 
     target_cmd_build($ho, 300, $builddir, <<END);
 	mkdir -p dist/boot dist/lib/modules
-- 
2.5.3

  parent reply	other threads:[~2015-10-02  9:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02  9:25 [PATCH OSSTEST 0/8] Use the DTB provided by the kernel we are trying to boot Ian Campbell
2015-10-02  9:26 ` [PATCH OSSTEST 1/8] Osstest: Add %arch_debian2linux (and inverse) Ian Campbell
2015-10-05 16:18   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 2/8] ts-kernel-build: Introduce global $parms Ian Campbell
2015-10-05 16:18   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 3/8] ts-kernel-build: Refactor $archparams::DefConfig selection Ian Campbell
2015-10-05 16:19   ` Ian Jackson
2015-10-02  9:26 ` Ian Campbell [this message]
2015-10-05 16:19   ` [PATCH OSSTEST 4/8] ts-kernel-build: Refactor $archparams KernelImage handling Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 5/8] ts-kernel-build: Add arm64 support Ian Campbell
2015-10-05 16:20   ` Ian Jackson
2015-10-05 16:28     ` Ian Campbell
2015-10-06 13:35       ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs in dist file Ian Campbell
2015-10-05 16:22   ` Ian Jackson
2015-10-05 16:29     ` Ian Campbell
2015-10-06 13:24       ` Ian Campbell
2015-10-06 13:36         ` Ian Jackson
2015-10-06 13:36       ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 7/8] Debian: Enable interpolation in uboot_scr_load_dtb here doc Ian Campbell
2015-10-05 16:24   ` Ian Jackson
2015-10-05 16:30     ` Ian Campbell
2015-10-02  9:26 ` [PATCH OSSTEST 8/8] Debian: Use dtbs from kernel dist when booting that kernel Ian Campbell
2015-10-05 16:29   ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443777978-11119-4-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).