xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST 8/8] Debian: Use dtbs from kernel dist when booting that kernel
Date: Fri, 2 Oct 2015 10:26:18 +0100	[thread overview]
Message-ID: <1443777978-11119-8-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1443777956.11707.61.camel@citrix.com>

The kernel dist built by ts-kernel-build puts the corresponding dtbs
into /boot/dtbs/$kvers.

The host installers dtbs remain in /boot/dtbs and are used when
booting the native kernel.

It's possible that this change will expose bugs which exist in the
DTBs in previous kernel branches (3.18 and 4.1). I've not
investigated, I think we should accept this possibility and deal with
it via backport requests (and maybe some force pushes if appropriate)
as necessary.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest/Debian.pm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 75fd7bf..4df1b74 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -141,11 +141,14 @@ sub uboot_common_kernel_bootargs ($)
     return @bootargs;
 }
 
-sub uboot_scr_load_dtb () {
+sub uboot_scr_load_dtb (;$) {
+    my ($kvers) = @_;
+    $kvers ||= '';
+    $kvers .= '/' if $kvers;
     return <<END;
 if test -z "\\\${fdt_addr}" && test -n "\\\${fdtfile}" ; then
-    echo Loading dtbs/\\\${fdtfile}
-    ext2load scsi 0 \\\${fdt_addr_r} dtbs/\\\${fdtfile}
+    echo Loading dtbs/$kvers\\\${fdtfile}
+    ext2load scsi 0 \\\${fdt_addr_r} dtbs/$kvers\\\${fdtfile}
     setenv fdt_addr \\\${fdt_addr_r}
 fi
 END
@@ -228,7 +231,7 @@ END
 	my $early_commands = get_host_property($ho, 'UBootScriptEarlyCommands', '');
 	my $xen_addr_r = get_host_property($ho, 'UBootSetXenAddrR', undef);
 
-	my $load_dtb = uboot_scr_load_dtb();
+	my $load_dtb = uboot_scr_load_dtb($want_kernver);
 
 	my $set_xen_addr_r =
 	    $xen_addr_r ? "setenv xen_addr_r $xen_addr_r" : "";
-- 
2.5.3

  parent reply	other threads:[~2015-10-02  9:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02  9:25 [PATCH OSSTEST 0/8] Use the DTB provided by the kernel we are trying to boot Ian Campbell
2015-10-02  9:26 ` [PATCH OSSTEST 1/8] Osstest: Add %arch_debian2linux (and inverse) Ian Campbell
2015-10-05 16:18   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 2/8] ts-kernel-build: Introduce global $parms Ian Campbell
2015-10-05 16:18   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 3/8] ts-kernel-build: Refactor $archparams::DefConfig selection Ian Campbell
2015-10-05 16:19   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 4/8] ts-kernel-build: Refactor $archparams KernelImage handling Ian Campbell
2015-10-05 16:19   ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 5/8] ts-kernel-build: Add arm64 support Ian Campbell
2015-10-05 16:20   ` Ian Jackson
2015-10-05 16:28     ` Ian Campbell
2015-10-06 13:35       ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs in dist file Ian Campbell
2015-10-05 16:22   ` Ian Jackson
2015-10-05 16:29     ` Ian Campbell
2015-10-06 13:24       ` Ian Campbell
2015-10-06 13:36         ` Ian Jackson
2015-10-06 13:36       ` Ian Jackson
2015-10-02  9:26 ` [PATCH OSSTEST 7/8] Debian: Enable interpolation in uboot_scr_load_dtb here doc Ian Campbell
2015-10-05 16:24   ` Ian Jackson
2015-10-05 16:30     ` Ian Campbell
2015-10-02  9:26 ` Ian Campbell [this message]
2015-10-05 16:29   ` [PATCH OSSTEST 8/8] Debian: Use dtbs from kernel dist when booting that kernel Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443777978-11119-8-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).