From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [OSSTEST PATCH 1/2] TestSupport.pm: allow creating vNUMA enabled HVM guest configs Date: Fri, 2 Oct 2015 14:02:15 +0200 Message-ID: <1443787335.14525.62.camel@citrix.com> References: <20151001230750.15271.26071.stgit@Solace.station> <20151001231731.15271.87986.stgit@Solace.station> <20151002113242.GA30122@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0715972592933105973==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zhz32-0001PC-RM for xen-devel@lists.xenproject.org; Fri, 02 Oct 2015 12:02:48 +0000 In-Reply-To: <20151002113242.GA30122@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, Dario Faggioli , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============0715972592933105973== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-na0Hq8kepWDbJxp4cJs8" --=-na0Hq8kepWDbJxp4cJs8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-10-02 at 12:32 +0100, Wei Liu wrote: > On Fri, Oct 02, 2015 at 01:17:31AM +0200, Dario Faggioli wrote: > > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm > > index 2b67e32..bf8bd56 100644 > > --- a/Osstest/TestSupport.pm > > +++ b/Osstest/TestSupport.pm > > @@ -1709,6 +1709,34 @@ sub prepareguest_part_xencfg ($$$$$) { > > + # Let's put all vnodes on pnode 0, as we don't even know > > (for now) > > + # whether or not the host has more NUMA nodes than that! > > + @vnuma_pnode =3D (0) x $vnuma_nodes; > > + >=20 > The thing I worry about putting everything in node 0 is that if we > somehow has hardware that has several nodes but each node has > relative > small amount of ram it would cause this test case to fail. >=20 ISWYM. > In the current arrangement, HVM guest gets 5G of ram if OSSTest > determines the host has enough (2x5G + slack) ram for it. So vnuma > test > case will fail on a box with 4 nodes but has 16G of ram. Is such > hardware configuration not very likely to exist? >=20 Well, 16GB is a rather small amount of RAM for a box with 4 nodes, IMO. However, I think your point is valid... I think I can, in case vnuma_nodes is provided, overrun $ram_mb with something more likely to fit on one physical node? Unfortunately, it's not something we can check precisely, because, in Xen, there is (yet) no mechanism to know, in case we have XX free RAM (apart from parsing the console output after issuing `xl debug-key u', which is really really unpractical!), how many of it actually comes from each NUMA ndoe... but I can apply a bit of guessing. What do you think? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-na0Hq8kepWDbJxp4cJs8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYOckcACgkQk4XaBE3IOsTQWwCcCCnTvxdWJldi5U9DBJwzei1c QygAniH27fkTwa31NeMr6IaEo1XgjBJl =3fSw -----END PGP SIGNATURE----- --=-na0Hq8kepWDbJxp4cJs8-- --===============0715972592933105973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0715972592933105973==--