From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH OSSTEST v2 3/3] standalone: Make it possible to pass options to run-test
Date: Mon, 5 Oct 2015 14:47:47 +0100 [thread overview]
Message-ID: <1444052867.5302.2.camel@citrix.com> (raw)
In-Reply-To: <22034.22017.184756.634540@mariner.uk.xensource.com>
On Mon, 2015-10-05 at 11:50 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 3/3] standalone: Make it possible
> to pass options to run-test"):
> > Currently the remainder of the comnand line is passed after the host=
> > ident, which allows for other idents to be given, which isn't all that
> > useful in practice.
> ...
> > + options=
> > + for i in $@ ; do
> > + if [ x$i = x-- ] ; then shift; break ; fi
> > + options="$options $i"
> > + shift
> > + done
>
> Please use an array variable so that it is possible to pass options
> containing whitespace etc. Sorry; I realise this is a very marginal
> use case but it's definitely a good idea not to paint oneself into a
> corner about this kind of thing.
Ack.
prev parent reply other threads:[~2015-10-05 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 12:05 [PATCH OSSTEST v2 0/3] Misc standalone wrapper improvements Ian Campbell
2015-10-02 12:05 ` [PATCH OSSTEST v2 1/3] cs-adjust-flight: Add job-status to report job stats Ian Campbell
2015-10-05 10:48 ` Ian Jackson
2015-10-05 13:53 ` Ian Campbell
2015-10-02 12:05 ` [PATCH OSSTEST v2 2/3] standalone: Check job status at end of run-job Ian Campbell
2015-10-02 12:05 ` [PATCH OSSTEST v2 3/3] standalone: Make it possible to pass options to run-test Ian Campbell
2015-10-05 10:50 ` Ian Jackson
2015-10-05 13:47 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444052867.5302.2.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).