From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v8] run QEMU as non-root Date: Mon, 5 Oct 2015 17:20:54 +0100 Message-ID: <1444062054.5302.27.camel@citrix.com> References: <1443627946-4716-1-git-send-email-stefano.stabellini@eu.citrix.com> <1443788231.11707.84.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xensource.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-10-05 at 16:53 +0100, Stefano Stabellini wrote: > > Wasn't there some code to plumb this into xl at one point? Did that get > > dropped along the way? > > device_model_user is added to the idl by this patch, I think that is > enough, right? Depends what you mean by "enough", it adds it to the _libxl_ API, which is sufficient for the patch to be useful but it doesn't actually cause the option to be available to users of xl via a cfg file, which arguably it should. To make it available to xl users patches to tools/libxl/xl_cmdimpl.c would be needed (plus docs changes) Ian.