From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs in dist file Date: Mon, 5 Oct 2015 17:29:30 +0100 Message-ID: <1444062570.5302.30.camel@citrix.com> References: <1443777956.11707.61.camel@citrix.com> <1443777978-11119-6-git-send-email-ian.campbell@citrix.com> <22034.41945.374098.843872@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22034.41945.374098.843872@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-10-05 at 17:22 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST 6/8] ts-kernel-build: Include dtbs > in dist file"): > > These are installed to $(INSTALL_PATH)/dtbs/$(KERNEL_RELEASE) where > > $(INSTALL_PATH) defaults to /boot but we override it to our staging > > /boot. > > Thanks for the detailed explanation. > > Acked-by: Ian Jackson > > > - make $makeflags INSTALL_MOD_PATH=$builddir/dist > > modules_install > > + make $makeflags \\ > > + INSTALL_PATH=$builddir/dist/boot \\ > > + INSTALL_MOD_PATH=$builddir/dist modules_install \\ > > + $dtbs_install > > I tripped over the formatting here. It would be nicer to put > `modules_install' on the next line, to avoid hiding it in > INSTALL_BLAH=. I did it that way because INSTALL_MOD_PATH is the variable which controls where modules_install puts things, so they are in some sense related. Next line is fine too, or I could move it to first on the line it is on now? Ian.