From: Ian Campbell <ian.campbell@citrix.com>
To: "Juergen Gross" <jgross@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: pyxc_linux_build() in tools/python/xen/lowlevel/xc/xc.c still needed?
Date: Tue, 6 Oct 2015 09:56:21 +0100 [thread overview]
Message-ID: <1444121781.5302.52.camel@citrix.com> (raw)
In-Reply-To: <56136B21.1030704@suse.com>
On Tue, 2015-10-06 at 08:33 +0200, Juergen Gross wrote:
> Do we have any requirements to be compatible to old releases regarding
> the functions in tools/python/xen/lowlevel/xc/xc.c ?
IMHO, no.
There are also too many compatibility shims in front of the domain builder,
i.e. all the stuff in tools/libxc/xc_dom_compat_linux.c which IMHO could be
nuked too.
> Especially pyxc_linux_build() isn't used anywhere in the tree. And this
> is the only function setting xc_dom_image.superpages, thus removing it
> would give us the chance to remove some code of the domain builder.
Right.
Removing the superpages option from the non-Python might cause concern for
some. Adding Konrad since IIRC PV superpages is a thing Oracle implemented
and might still care about.
Also adding Roger since he is reworking the HVM builder to use the PV one,
which for all I know might involve using the superpage option (but probably
not the PV code to set it up).
Also CCing the other tools/libxc maintainers.
Ian.
next prev parent reply other threads:[~2015-10-06 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 6:33 pyxc_linux_build() in tools/python/xen/lowlevel/xc/xc.c still needed? Juergen Gross
2015-10-06 8:56 ` Ian Campbell [this message]
2015-10-06 9:02 ` Juergen Gross
2015-10-06 9:11 ` Roger Pau Monné
2015-10-06 9:32 ` Andrew Cooper
2015-10-06 9:34 ` Andrew Cooper
2015-10-06 10:01 ` Ian Campbell
2015-10-06 10:56 ` Juergen Gross
2015-10-06 11:08 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444121781.5302.52.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).