From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: pyxc_linux_build() in tools/python/xen/lowlevel/xc/xc.c still needed? Date: Tue, 6 Oct 2015 09:56:21 +0100 Message-ID: <1444121781.5302.52.camel@citrix.com> References: <56136B21.1030704@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56136B21.1030704@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , "xen-devel@lists.xen.org" , Konrad Rzeszutek Wilk , Roger Pau =?ISO-8859-1?Q?Monn=E9?= Cc: Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Tue, 2015-10-06 at 08:33 +0200, Juergen Gross wrote: > Do we have any requirements to be compatible to old releases regarding > the functions in tools/python/xen/lowlevel/xc/xc.c ? IMHO, no. There are also too many compatibility shims in front of the domain builder, i.e. all the stuff in tools/libxc/xc_dom_compat_linux.c which IMHO could be nuked too. > Especially pyxc_linux_build() isn't used anywhere in the tree. And this > is the only function setting xc_dom_image.superpages, thus removing it > would give us the chance to remove some code of the domain builder. Right. Removing the superpages option from the non-Python might cause concern for some. Adding Konrad since IIRC PV superpages is a thing Oracle implemented and might still care about. Also adding Roger since he is reworking the HVM builder to use the PV one, which for all I know might involve using the superpage option (but probably not the PV code to set it up). Also CCing the other tools/libxc maintainers. Ian.