From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: pyxc_linux_build() in
 tools/python/xen/lowlevel/xc/xc.c still needed?
Date: Tue, 6 Oct 2015 12:08:20 +0100
Message-ID: <1444129700.5302.134.camel@citrix.com>
References: <56136B21.1030704@suse.com>	 <1444121781.5302.52.camel@citrix.com>
	<5613A8F3.9050300@suse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5613A8F3.9050300@suse.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Juergen Gross <jgross@suse.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Roger Pau =?ISO-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-10-06 at 12:56 +0200, Juergen Gross wrote:
> On 10/06/2015 10:56 AM, Ian Campbell wrote:
> > On Tue, 2015-10-06 at 08:33 +0200, Juergen Gross wrote:
> > > Do we have any requirements to be compatible to old releases
> > > regarding
> > > the functions in tools/python/xen/lowlevel/xc/xc.c ?
> > 
> > IMHO, no.
> > 
> > There are also too many compatibility shims in front of the domain
> > builder,
> > i.e. all the stuff in tools/libxc/xc_dom_compat_linux.c which IMHO
> > could be
> > nuked too.
> 
> Hmm, all of the functions there are defined in xenguest.h and are
> probably used by out-of-tree components.
> 
> xc_linux_build() is used in qemu-xen in file /hw/xenpv/xen_domainbuild.c
> 
> Is it really okay to remove all of this stuff?

In general, yes, I think so. But in the specific case of xc_linux_build I
suppose not, at least for now.

As part of my series to split up libxenctrl I noticed that the QEMU support
for domain building couldn't possibly have worked (according to a code
comment) since Xen 4.1 and I've got a patch to make it a compile time
option.

Ian