From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH OSSTEST v2 1/8] Debian: uboot: Use di_vg_name() and lv_dev_mapper() for root=
Date: Tue, 6 Oct 2015 13:46:59 +0100 [thread overview]
Message-ID: <1444135626-1771-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1444135606.5302.145.camel@citrix.com>
root is not a "guest lv", so using target_guest_lv_name is misleading.
target_guest_lv_name also fails to properly handle the d-i vg name
correctly, which di_vg_name does. Specifically under Jessie an extra
"-vg" is appended to the hostname compared with Wheezy and Squeeze.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
Osstest/Debian.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm
index 153b375..9347c49 100644
--- a/Osstest/Debian.pm
+++ b/Osstest/Debian.pm
@@ -131,7 +131,7 @@ sub uboot_common_kernel_bootargs ($)
{
my ($ho) = @_;
- my $root= target_guest_lv_name($ho,"root");
+ my $root= lv_dev_mapper(di_vg_name($ho),"root");
my $rootdelay= get_host_property($ho, "rootdelay");
my @bootargs;
--
2.5.3
next prev parent reply other threads:[~2015-10-06 12:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:46 [PATCH OSSTEST v2 0/8] Fixes for switching to Jessie as base OS for test hosts Ian Campbell
2015-10-06 12:46 ` Ian Campbell [this message]
2015-10-06 12:47 ` [PATCH OSSTEST v2 2/8] TestSupport: Use lv_dev_mapper in guest_find_lv Ian Campbell
2015-10-06 12:47 ` [PATCH OSSTEST v2 3/8] ts-freebsd-install: Use $gho->{Lvdev} instead of target_guest_lv_name Ian Campbell
2015-10-06 12:47 ` [PATCH OSSTEST v2 4/8] TestSupport: Remove now unused target_guest_lv_name Ian Campbell
2015-10-06 12:47 ` [PATCH OSSTEST v2 5/8] ts-kernel-build: Explicitly enable CONFIG_CGROUPS Ian Campbell
2015-10-06 15:05 ` Ian Jackson
2015-10-06 15:19 ` Ian Campbell
2015-10-06 15:32 ` Ian Jackson
2015-10-06 12:47 ` [PATCH OSSTEST v2 6/8] ts-debian-di-install: Use correct per-arch name for kernel Ian Campbell
2015-10-06 15:15 ` Ian Jackson
2015-10-06 12:47 ` [PATCH OSSTEST v2 7/8] ts-freebsd-install: Pass -s option to kpartx Ian Campbell
2015-10-06 15:16 ` Ian Jackson
2015-10-06 15:39 ` Ian Campbell
2015-10-06 12:47 ` [PATCH OSSTEST v2 8/8] Switch to Debian 8.0 (jessie) as OS for test hosts Ian Campbell
2015-10-08 16:17 ` [PATCH OSSTEST v2 0/8] Fixes for switching to Jessie as base " Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444135626-1771-1-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).