From: Ian Campbell <ian.campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian.Jackson@eu.citrix.com, xen-devel@lists.xensource.com,
wei.liu2@citrix.com
Subject: Re: [PATCH v8] run QEMU as non-root
Date: Tue, 6 Oct 2015 14:30:20 +0100 [thread overview]
Message-ID: <1444138220.5302.169.camel@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1510061412270.1179@kaball.uk.xensource.com>
On Tue, 2015-10-06 at 14:13 +0100, Stefano Stabellini wrote:
> On Mon, 5 Oct 2015, Ian Campbell wrote:
> > On Mon, 2015-10-05 at 16:53 +0100, Stefano Stabellini wrote:
> > > > Wasn't there some code to plumb this into xl at one point? Did that
> > > > get
> > > > dropped along the way?
> > >
> > > device_model_user is added to the idl by this patch, I think that is
> > > enough, right?
> >
> > Depends what you mean by "enough", it adds it to the _libxl_ API, which
> > is
> > sufficient for the patch to be useful but it doesn't actually cause the
> > option to be available to users of xl via a cfg file, which arguably it
> > should.
> >
> > To make it available to xl users patches to tools/libxl/xl_cmdimpl.c
> > would
> > be needed (plus docs changes)
>
> I see. No, xl_cmdimpl.c support for the option was never written, as it
> was introduced principally for libvirt's benefit.
Ah, I was wondering how this had been tested...
Ian.
next prev parent reply other threads:[~2015-10-06 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 15:45 [PATCH v8] run QEMU as non-root Stefano Stabellini
2015-10-02 12:17 ` Ian Campbell
2015-10-05 15:53 ` Stefano Stabellini
2015-10-05 16:20 ` Ian Campbell
2015-10-06 13:13 ` Stefano Stabellini
2015-10-06 13:30 ` Ian Campbell [this message]
2015-10-06 15:29 ` Jim Fehlig
2015-10-07 11:15 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444138220.5302.169.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).