From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST 4/5] standalone: Make it possible to pass options to run-test Date: Tue, 6 Oct 2015 16:35:45 +0100 Message-ID: <1444145745.5302.225.camel@citrix.com> References: <1444055694.5302.9.camel@citrix.com> <1444055708-15836-4-git-send-email-ian.campbell@citrix.com> <22035.57011.846613.713602@mariner.uk.xensource.com> <1444143568.5302.211.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1444143568.5302.211.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-10-06 at 15:59 +0100, Ian Campbell wrote: > On Tue, 2015-10-06 at 15:46 +0100, Ian Jackson wrote: > > Ian Campbell writes ("[PATCH OSSTEST 4/5] standalone: Make it possible > > to > > pass options to run-test"): > > > Currently the remainder of the comnand line is passed after the host= > > > ident, which allows for other idents to be given, which isn't all > > > that > > > useful in practice. > > > > > > Instead arrange that any additional options up to a "--" marker are > > > passed before host= and anything after are passed after. > > ... > > > - with_logging logs/$flight/$job.$ts.log ./$ts $hosts $@ > > > + with_logging logs/$flight/$job.$ts.log ./$ts > > > ${options[@]} > > > $hosts $@ > > > > You mean ... ./$ts "${options[@]}" $hosts ... > > by analogy with "$@" > > We (well, I, since I wrote that) don't use "$@" above but just the bare > $@, > which I copied. I suppose that one is wrong too? I've decided it is and will insert a patch to fixup various unquoted uses of $@. Also in this patch was + for i in $@ ; do which is similarly wrong, I think.