xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
@ 2015-10-06 16:58 Sander Eikelenboom
  2015-10-07 10:16 ` Wei Liu
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Sander Eikelenboom @ 2015-10-06 16:58 UTC (permalink / raw)
  To: xen-devel; +Cc: Sander Eikelenboom, wei.liu2

When building on 64-bit platforms this prevents  build errors for
32-bit components which are enabled on a default build.

Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
---
 README | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/README b/README
index a7d0033..1324c7c 100644
--- a/README
+++ b/README
@@ -56,6 +56,9 @@ provided by your OS distributor:
     * GNU gettext
     * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)
     * ACPI ASL compiler (iasl)
+    * Libc multiarch package (e.g. libc6-dev-i386 / glibc-devel.i686).
+      Required when building on a 64-bit platform to build
+      32-bit components which are enabled on a default build.
 
 In addition to the above there are a number of optional build
 prerequisites. Omitting these will cause the related features to be
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
  2015-10-06 16:58 [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README Sander Eikelenboom
@ 2015-10-07 10:16 ` Wei Liu
  2015-10-07 11:52 ` Ian Campbell
  2015-10-07 13:26 ` Ian Campbell
  2 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2015-10-07 10:16 UTC (permalink / raw)
  To: Sander Eikelenboom
  Cc: wei.liu2, keir, Ian Campbell, tim, Ian Jackson, xen-devel

CC people from ./get_maintainers.pl

On Tue, Oct 06, 2015 at 06:58:25PM +0200, Sander Eikelenboom wrote:
> When building on 64-bit platforms this prevents  build errors for
> 32-bit components which are enabled on a default build.
> 
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> ---
>  README | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README b/README
> index a7d0033..1324c7c 100644
> --- a/README
> +++ b/README
> @@ -56,6 +56,9 @@ provided by your OS distributor:
>      * GNU gettext
>      * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 & bcc debs)
>      * ACPI ASL compiler (iasl)
> +    * Libc multiarch package (e.g. libc6-dev-i386 / glibc-devel.i686).
> +      Required when building on a 64-bit platform to build
> +      32-bit components which are enabled on a default build.
>  
>  In addition to the above there are a number of optional build
>  prerequisites. Omitting these will cause the related features to be
> -- 
> 2.1.4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
  2015-10-06 16:58 [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README Sander Eikelenboom
  2015-10-07 10:16 ` Wei Liu
@ 2015-10-07 11:52 ` Ian Campbell
  2015-10-07 13:06   ` Sander Eikelenboom
  2015-10-07 13:26 ` Ian Campbell
  2 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-10-07 11:52 UTC (permalink / raw)
  To: Sander Eikelenboom, xen-devel; +Cc: wei.liu2

On Tue, 2015-10-06 at 18:58 +0200, Sander Eikelenboom wrote:
> When building on 64-bit platforms this prevents  build errors for
> 32-bit components which are enabled on a default build.
> 
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>

Acked + applied, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
  2015-10-07 11:52 ` Ian Campbell
@ 2015-10-07 13:06   ` Sander Eikelenboom
  2015-10-07 13:10     ` Wei Liu
  0 siblings, 1 reply; 6+ messages in thread
From: Sander Eikelenboom @ 2015-10-07 13:06 UTC (permalink / raw)
  To: Ian Campbell; +Cc: xen-devel, wei.liu2

On 2015-10-07 13:52, Ian Campbell wrote:
> On Tue, 2015-10-06 at 18:58 +0200, Sander Eikelenboom wrote:
>> When building on 64-bit platforms this prevents  build errors for
>> 32-bit components which are enabled on a default build.
>> 
>> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> 
> Acked + applied, thanks.

Thanks.
There also seems to be a little inconsistency on the wiki on page:
http://wiki.xenproject.org/wiki/Compiling_Xen_From_Source

The list of packages for yum (Redhat/Fedora) already includes 
glibc-devel.i686,
however the list of apt-get (Debian) packages doesn't include the libc 
multiarch package yet.

(Don't think i have any wiki access any more, or at least i can't 
remember the login)

--
Sander

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
  2015-10-07 13:06   ` Sander Eikelenboom
@ 2015-10-07 13:10     ` Wei Liu
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2015-10-07 13:10 UTC (permalink / raw)
  To: Sander Eikelenboom; +Cc: xen-devel, wei.liu2, Ian Campbell

On Wed, Oct 07, 2015 at 03:06:07PM +0200, Sander Eikelenboom wrote:
> On 2015-10-07 13:52, Ian Campbell wrote:
> >On Tue, 2015-10-06 at 18:58 +0200, Sander Eikelenboom wrote:
> >>When building on 64-bit platforms this prevents  build errors for
> >>32-bit components which are enabled on a default build.
> >>
> >>Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> >
> >Acked + applied, thanks.
> 
> Thanks.
> There also seems to be a little inconsistency on the wiki on page:
> http://wiki.xenproject.org/wiki/Compiling_Xen_From_Source
> 
> The list of packages for yum (Redhat/Fedora) already includes
> glibc-devel.i686,
> however the list of apt-get (Debian) packages doesn't include the libc
> multiarch package yet.
> 

Fixed.

> (Don't think i have any wiki access any more, or at least i can't remember
> the login)
> 
> --
> Sander

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README
  2015-10-06 16:58 [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README Sander Eikelenboom
  2015-10-07 10:16 ` Wei Liu
  2015-10-07 11:52 ` Ian Campbell
@ 2015-10-07 13:26 ` Ian Campbell
  2 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-10-07 13:26 UTC (permalink / raw)
  To: Sander Eikelenboom, xen-devel; +Cc: wei.liu2

On Tue, 2015-10-06 at 18:58 +0200, Sander Eikelenboom wrote:
> When building on 64-bit platforms this prevents  build errors for
> 32-bit components which are enabled on a default build.
> 
> Signed-off-by: Sander Eikelenboom <linux@eikelenboom.it>
> ---
>  README | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/README b/README
> index a7d0033..1324c7c 100644
> --- a/README
> +++ b/README
> @@ -56,6 +56,9 @@ provided by your OS distributor:
>      * GNU gettext
>      * 16-bit x86 assembler, loader and compiler (dev86 rpm or bin86 &
> bcc debs)
>      * ACPI ASL compiler (iasl)
> +    * Libc multiarch package (e.g. libc6-dev-i386 / glibc-devel.i686).

BTW, to be completely pedantic these are "biarch" packages.

Under Debian the "multiarch" package would be libc6-dev:i386 and you would
need to have run "dpkg --add-architecture=i386" at some point.

libc6-dev:i386 is the actual dev package from the i386 repository as
opposed to a special libc6-dev-i386 in the amd64 repository.

I don't believe the RPM world has anything equivalent to multiarch.

I'm not proposing we change anything though and I think libc6-dev-i386 is
the right thing to be recommending for the time being.

Ian.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-10-07 13:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-06 16:58 [PATCH] Add Libc multiarch package as build prerequisites on 64-bit platforms to the README Sander Eikelenboom
2015-10-07 10:16 ` Wei Liu
2015-10-07 11:52 ` Ian Campbell
2015-10-07 13:06   ` Sander Eikelenboom
2015-10-07 13:10     ` Wei Liu
2015-10-07 13:26 ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).