* [PATCH OSSTEST] standalone: do not rotate empty log files. @ 2015-10-07 8:25 Ian Campbell 2015-10-07 9:57 ` Ian Jackson 0 siblings, 1 reply; 3+ messages in thread From: Ian Campbell @ 2015-10-07 8:25 UTC (permalink / raw) To: ian.jackson, xen-devel; +Cc: Ian Campbell By passing -n to savelog. In particular this prevents the creation of an empty $log.0 on first use when $log doesn't exist. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- standalone | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/standalone b/standalone index 27e2e7d..d9c927f 100755 --- a/standalone +++ b/standalone @@ -192,7 +192,7 @@ ensure_logs() { with_logging() { local log=$1; shift ensure_logs - savelog -c 300 "$log" >/dev/null + savelog -c -n 300 "$log" >/dev/null "$@" 2>&1 | tee "$log" rc=${PIPESTATUS[0]} if [ $rc -ne 0 ] ; then -- 2.5.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH OSSTEST] standalone: do not rotate empty log files. 2015-10-07 8:25 [PATCH OSSTEST] standalone: do not rotate empty log files Ian Campbell @ 2015-10-07 9:57 ` Ian Jackson 2015-10-07 14:54 ` Ian Campbell 0 siblings, 1 reply; 3+ messages in thread From: Ian Jackson @ 2015-10-07 9:57 UTC (permalink / raw) To: Ian Campbell; +Cc: xen-devel Ian Campbell writes ("[PATCH OSSTEST] standalone: do not rotate empty log files."): > By passing -n to savelog. > > In particular this prevents the creation of an empty $log.0 on first > use when $log doesn't exist. Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH OSSTEST] standalone: do not rotate empty log files. 2015-10-07 9:57 ` Ian Jackson @ 2015-10-07 14:54 ` Ian Campbell 0 siblings, 0 replies; 3+ messages in thread From: Ian Campbell @ 2015-10-07 14:54 UTC (permalink / raw) To: Ian Jackson; +Cc: xen-devel On Wed, 2015-10-07 at 10:57 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] standalone: do not rotate empty log > files."): > > By passing -n to savelog. > > > > In particular this prevents the creation of an empty $log.0 on first > > use when $log doesn't exist. > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> "savelog -c -n 300" is bogus, it needs to be "savelog -c 300 -n". I could have sworn I ran it... ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-07 14:54 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-07 8:25 [PATCH OSSTEST] standalone: do not rotate empty log files Ian Campbell 2015-10-07 9:57 ` Ian Jackson 2015-10-07 14:54 ` Ian Campbell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).