xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: xen-devel <xen-devel@lists.xen.org>
Cc: minios-devel@lists.xenproject.org,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: [PATCH v3 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries
Date: Wed, 7 Oct 2015 15:02:23 +0100	[thread overview]
Message-ID: <1444226543.1410.53.camel@citrix.com> (raw)

In <1431963008.4944.80.camel@citrix.com> I proposed stabilising some
parts of the libxenctrl API/ABI by disaggregating into separate
libraries.

This is v3 of that set of series against:
    xen
    qemu-xen (new this time)
    qemu-xen-traditional
    mini-os

NB: minios-devel will only get the mini-os side and Stefano the qemu-xen
side.

The code in for all repos can be found in:

git://xenbits.xen.org/people/ianc/libxenctrl-split/xen.git                  v3
git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen.git             v3
git://xenbits.xen.org/people/ianc/libxenctrl-split/qemu-xen-traditional.git v3
git://xenbits.xen.org/people/ianc/libxenctrl-split/mini-os.git              v3

(nb the repos have changed since last time, I've carried the v2 tags over
as well)

The tip of the xen.git branch contains an extra patch adding a .config
into the tree which should get the correct things for the HEAD of the
branch, but not further back.

The new libraries here are:

 * libxentoollog: Common logging infrastructure
 * libxenevtchn: Userspace access to evtchns (via /dev/xen/evtchn etc)
 * libxengnttab: Userspace access to grant tables (via /dev/xen/gnt??? etc)
 * libxencall: Making hypercalls (i.e. the IOCTL_PRIVCMD_HYPERCALL type
   functionality)
 * libxenforeignmemory: Privileged mappings of foreign memory
   (IOCTL_PRIVCMD_MMAP et al)

The first three were actually pretty distinct within libxenctrl already and
have not changed in quite some time.

Although the other two are somewhat new they are based on top of long
standing stable ioctls, which gives me some confidence.

Nonetheless I would appreciate extra review of at least the interface
headers of all of these with a particular eye to the suitability of these
interfaces being maintained in an ABI (_B_, not _P_) stable way going
forward.

Still to come would be libraries for specific out of tree purposes
(device model, kexec), which would be adding new library at the same
level as libxc I think, rather than underneath, i.e. also using the
libraries split out here, but hopefully not libxenctrl itself.

The new libraries use linker version-scripts to hopefully make future
ABI changes be possible in a compatible way.

Since last time I have:

 * Moved everything from tools/libxenfoo to tools/libs/foo
 * Added patches to qemu-xen to use the new libraries instead of the compat
   layer. These can come any time after this transition and are not
   entangled (due to the compat layer being present in the meantime)
 * Reviewed each of the new libraries for
    * Error handling, Specifically no return -errno type stuff, but instead
      return -1 or NULL and setting errno if necessary
    * Appropriate types (some discussion around that hasn't been folded in
      here yet)
    * No inlines in the pubic headers (troublesome for ABI compatibility)
    * Documentation, in that they all have some, not that it is necessarily
      comprehensive or complete (although it does look better than the
      average).
 * Dropped 
    and you
   can find its history
 * Fixed various issue.

The whole thing has been build and runtime tested on Linux and stubdoms,
and built (but not run) on FreeBSD. Neither NetBSD nor Solaris have been
tested at all. It's certainly not impossible that I've not got the
#includes in the new files quite right.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2015-10-07 14:02 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 14:02 Ian Campbell [this message]
2015-10-07 14:10 ` [PATCH v3 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries Ian Jackson
2015-10-07 14:18   ` Ian Campbell
2015-10-07 14:28     ` [Minios-devel] " Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 01/22] tools/Rules.mk: Properly handle libraries with recursive dependencies Ian Campbell
2015-10-08 11:21   ` Ian Jackson
2015-10-08 11:38     ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 02/22] tools: Refactor "xentoollog" into its own library Ian Campbell
2015-10-07 14:42   ` Andrew Cooper
2015-10-07 14:50     ` Ian Campbell
2015-10-08 10:17       ` Ian Jackson
2015-10-08 11:23   ` Ian Jackson
2015-10-08 11:34     ` Ian Campbell
2015-10-08 13:51       ` Ian Jackson
2015-10-07 14:15 ` [PATCH XEN v3 03/22] tools/libxc: Remove osdep indirection for xc_evtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 04/22] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 05/22] tools: Arrange to check public headers for ANSI compatiblity Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 06/22] tools/libxc: Remove osdep indirection for xc_gnt{shr, tab} Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 07/22] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 08/22] tools/libxc: Remove osdep indirection for privcmd Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 09/22] tools: Refactor hypercall calling wrappers into libxencall Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 10/22] tools/libxc: drop xc_map_foreign_bulk_compat wrappers Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 11/22] tools: Remove xc_map_foreign_batch Ian Campbell
2015-10-07 15:08   ` George Dunlap
2015-10-07 15:20     ` Ian Campbell
2015-10-14 15:05     ` Ian Campbell
2015-10-14 15:11       ` George Dunlap
2015-10-07 14:15 ` [PATCH XEN v3 12/22] tools: Implement xc_map_foreign_range(s) in terms of common helper Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 13/22] tools: Refactor foreign memory mapping into libxenforeignmemory Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 14/22] tools: foreignmemory: provide xenforeignmemory_unmap Ian Campbell
2015-10-07 15:03   ` Andrew Cooper
2015-10-07 15:16     ` Ian Campbell
2015-10-07 15:20       ` Andrew Cooper
2015-10-07 15:30         ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 15/22] tools/libs/evtchn: Review and update doc comments Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 16/22] tools/libs: Clean up hard tabs Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 17/22] tools/libs/gnttab: Review and update doc comments Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 18/22] tools/libs/call: Update some log messages to not refer to xc Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 19/22] tools/libs/call: Avoid xc_memalign in netbsd and solaris backends Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 20/22] tools/libs/foreignmemory: Mention restrictions on fork in docs Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 21/22] tools: Update CFLAGS for qemu-xen to allow it to use new libraries Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 22/22] HACK: Add a .config to pull all the right bits from my xenbits trees Ian Campbell
2015-10-07 14:15 ` [PATCH QEMU-XEN v3 1/8] xen: Switch to libxenevtchn interface for compat shims Ian Campbell
2015-10-07 14:36   ` Andrew Cooper
2015-10-07 14:48     ` Ian Campbell
2015-10-14 13:16   ` Stefano Stabellini
2015-10-14 13:25     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 2/8] xen: Switch to libxengnttab " Ian Campbell
2015-10-14 13:30   ` Stefano Stabellini
2015-10-14 13:40     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 3/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk Ian Campbell
2015-10-14 14:01   ` Stefano Stabellini
2015-10-14 14:20     ` Ian Campbell
2015-10-14 14:21       ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 4/8] xen: Switch uses of xc_map_foreign_pages " Ian Campbell
2015-10-14 14:03   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 5/8] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API Ian Campbell
2015-10-14 14:10   ` Stefano Stabellini
2015-10-14 14:31     ` Ian Campbell
2015-10-14 15:41       ` Stefano Stabellini
2015-10-14 15:59         ` Ian Campbell
2015-10-14 16:06           ` Ian Campbell
2015-10-14 16:29           ` Stefano Stabellini
2015-10-14 16:48             ` Ian Campbell
2015-10-14 17:17               ` Stefano Stabellini
2015-10-15 11:21                 ` Ian Campbell
2015-10-15 14:49                   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 6/8] xen: Use stable library interfaces when they are available Ian Campbell
2015-10-14 14:52   ` Stefano Stabellini
2015-10-15 14:23     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher Ian Campbell
2015-10-14 14:22   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 8/8] xen: make it possible to build without the Xen PV domain builder Ian Campbell
2015-10-14 14:24   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 1/5] qemu-xen-traditional: Use xentoollog as a separate library Ian Campbell
2015-10-08 11:33   ` Ian Jackson
2015-10-08 11:45     ` Ian Campbell
2015-10-08 13:53       ` Ian Jackson
2015-10-08 14:05         ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 2/5] qemu-xen-traditional: Use libxenevtchn Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 3/5] qemu-xen-traditional: Use libxengnttab Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 4/5] qemu-xen-traditional: Add libxencall to rpath-link Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 5/5] qemu-xen-traditional: Add libxenforeignmemory " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 1/5] mini-os: Include libxentoollog with libxc Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 2/5] mini-os: Include libxenevtchn " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 3/5] mini-os: Include libxengnttab " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 4/5] mini-os: Include libxencall " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 5/5] mini-os: Include libxenforeignmemory " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444226543.1410.53.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=minios-devel@lists.xenproject.org \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).