xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH XEN v3 17/22] tools/libs/gnttab: Review and update doc comments.
Date: Wed, 7 Oct 2015 15:15:36 +0100	[thread overview]
Message-ID: <1444227341-875-17-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1444226543.1410.53.camel@citrix.com>

Remove some stray xc references.

While I'm not convinced by javadoc/doxygen cause the existing comments
which appear to use that syntax to have the appropriate /** marker.

Also fix a typo in a code comment.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 tools/libs/gnttab/include/xengnttab.h | 21 +++++++++++----------
 tools/libs/gnttab/linux.c             |  2 +-
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/tools/libs/gnttab/include/xengnttab.h b/tools/libs/gnttab/include/xengnttab.h
index c810c07..e091fa6 100644
--- a/tools/libs/gnttab/include/xengnttab.h
+++ b/tools/libs/gnttab/include/xengnttab.h
@@ -38,9 +38,9 @@ typedef struct xengntdev_handle xengnttab_handle;
 
 /*
  * Note:
- * After fork a child process must not use any opened xc gnttab
+ * After fork a child process must not use any opened gnttab
  * handle inherited from their parent. They must open a new handle if
- * they want to interact with xc.
+ * they want to interact with gnttab.
  *
  * Return an fd onto the grant table driver.  Logs errors.
  */
@@ -52,7 +52,7 @@ xengnttab_handle *xengnttab_open(xentoollog_logger *logger, unsigned open_flags)
  */
 int xengnttab_close(xengnttab_handle *xgt);
 
-/*
+/**
  * Memory maps a grant reference from one domain to a local address range.
  * Mappings should be unmapped with xengnttab_munmap.  Logs errors.
  *
@@ -124,7 +124,7 @@ void *xengnttab_map_grant_ref_notify(xengnttab_handle *xgt,
                                      uint32_t notify_offset,
                                      evtchn_port_t notify_port);
 
-/*
+/**
  * Unmaps the @count pages starting at @start_address, which were mapped by a
  * call to xengnttab_map_grant_ref or xengnttab_map_grant_refs. Never logs.
  */
@@ -132,7 +132,7 @@ int xengnttab_munmap(xengnttab_handle *xgt,
                      void *start_address,
                      uint32_t count);
 
-/*
+/**
  * Sets the maximum number of grants that may be mapped by the given instance
  * to @count.  Never logs.
  *
@@ -156,9 +156,9 @@ typedef struct xengntdev_handle xengntshr_handle;
  * Return an fd onto the grant sharing driver.  Logs errors.
  *
  * Note:
- * After fork a child process must not use any opened xc gntshr
+ * After fork a child process must not use any opened gntshr
  * handle inherited from their parent. They must open a new handle if
- * they want to interact with xc.
+ * they want to interact with gntshr.
  *
  */
 xengntshr_handle *xengntshr_open(xentoollog_logger *logger,
@@ -170,7 +170,7 @@ xengntshr_handle *xengntshr_open(xentoollog_logger *logger,
  */
 int xengntshr_close(xengntshr_handle *xgs);
 
-/*
+/**
  * Creates and shares pages with another domain.
  *
  * @parm xgs a handle to an open grant sharing instance
@@ -183,7 +183,7 @@ int xengntshr_close(xengntshr_handle *xgs);
 void *xengntshr_share_pages(xengntshr_handle *xgs, uint32_t domid,
                             int count, uint32_t *refs, int writable);
 
-/*
+/**
  * Creates and shares a page with another domain, with unmap notification.
  *
  * @parm xgs a handle to an open grant sharing instance
@@ -199,7 +199,8 @@ void *xengntshr_share_page_notify(xengntshr_handle *xgs, uint32_t domid,
                                   uint32_t *ref, int writable,
                                   uint32_t notify_offset,
                                   evtchn_port_t notify_port);
-/*
+
+/**
  * Unmaps the @count pages starting at @start_address, which were mapped by a
  * call to xengntshr_share_*. Never logs.
  */
diff --git a/tools/libs/gnttab/linux.c b/tools/libs/gnttab/linux.c
index a76f17f..bdf2a42 100644
--- a/tools/libs/gnttab/linux.c
+++ b/tools/libs/gnttab/linux.c
@@ -136,7 +136,7 @@ void *osdep_gnttab_grant_map(xengnttab_handle *xgt,
          * swapped out. Since the paging daemon may be in the same domain, the
          * hypercall cannot block without causing a deadlock.
          *
-         * Because there are no notificaitons when the page is swapped in, wait
+         * Because there are no notifications when the page is swapped in, wait
          * a bit before retrying, and hope that the page will arrive eventually.
          */
         usleep(1000);
-- 
2.1.4

  parent reply	other threads:[~2015-10-07 14:15 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 14:02 [PATCH v3 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-07 14:10 ` Ian Jackson
2015-10-07 14:18   ` Ian Campbell
2015-10-07 14:28     ` [Minios-devel] " Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 01/22] tools/Rules.mk: Properly handle libraries with recursive dependencies Ian Campbell
2015-10-08 11:21   ` Ian Jackson
2015-10-08 11:38     ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 02/22] tools: Refactor "xentoollog" into its own library Ian Campbell
2015-10-07 14:42   ` Andrew Cooper
2015-10-07 14:50     ` Ian Campbell
2015-10-08 10:17       ` Ian Jackson
2015-10-08 11:23   ` Ian Jackson
2015-10-08 11:34     ` Ian Campbell
2015-10-08 13:51       ` Ian Jackson
2015-10-07 14:15 ` [PATCH XEN v3 03/22] tools/libxc: Remove osdep indirection for xc_evtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 04/22] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 05/22] tools: Arrange to check public headers for ANSI compatiblity Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 06/22] tools/libxc: Remove osdep indirection for xc_gnt{shr, tab} Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 07/22] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 08/22] tools/libxc: Remove osdep indirection for privcmd Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 09/22] tools: Refactor hypercall calling wrappers into libxencall Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 10/22] tools/libxc: drop xc_map_foreign_bulk_compat wrappers Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 11/22] tools: Remove xc_map_foreign_batch Ian Campbell
2015-10-07 15:08   ` George Dunlap
2015-10-07 15:20     ` Ian Campbell
2015-10-14 15:05     ` Ian Campbell
2015-10-14 15:11       ` George Dunlap
2015-10-07 14:15 ` [PATCH XEN v3 12/22] tools: Implement xc_map_foreign_range(s) in terms of common helper Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 13/22] tools: Refactor foreign memory mapping into libxenforeignmemory Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 14/22] tools: foreignmemory: provide xenforeignmemory_unmap Ian Campbell
2015-10-07 15:03   ` Andrew Cooper
2015-10-07 15:16     ` Ian Campbell
2015-10-07 15:20       ` Andrew Cooper
2015-10-07 15:30         ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 15/22] tools/libs/evtchn: Review and update doc comments Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 16/22] tools/libs: Clean up hard tabs Ian Campbell
2015-10-07 14:15 ` Ian Campbell [this message]
2015-10-07 14:15 ` [PATCH XEN v3 18/22] tools/libs/call: Update some log messages to not refer to xc Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 19/22] tools/libs/call: Avoid xc_memalign in netbsd and solaris backends Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 20/22] tools/libs/foreignmemory: Mention restrictions on fork in docs Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 21/22] tools: Update CFLAGS for qemu-xen to allow it to use new libraries Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 22/22] HACK: Add a .config to pull all the right bits from my xenbits trees Ian Campbell
2015-10-07 14:15 ` [PATCH QEMU-XEN v3 1/8] xen: Switch to libxenevtchn interface for compat shims Ian Campbell
2015-10-07 14:36   ` Andrew Cooper
2015-10-07 14:48     ` Ian Campbell
2015-10-14 13:16   ` Stefano Stabellini
2015-10-14 13:25     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 2/8] xen: Switch to libxengnttab " Ian Campbell
2015-10-14 13:30   ` Stefano Stabellini
2015-10-14 13:40     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 3/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk Ian Campbell
2015-10-14 14:01   ` Stefano Stabellini
2015-10-14 14:20     ` Ian Campbell
2015-10-14 14:21       ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 4/8] xen: Switch uses of xc_map_foreign_pages " Ian Campbell
2015-10-14 14:03   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 5/8] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API Ian Campbell
2015-10-14 14:10   ` Stefano Stabellini
2015-10-14 14:31     ` Ian Campbell
2015-10-14 15:41       ` Stefano Stabellini
2015-10-14 15:59         ` Ian Campbell
2015-10-14 16:06           ` Ian Campbell
2015-10-14 16:29           ` Stefano Stabellini
2015-10-14 16:48             ` Ian Campbell
2015-10-14 17:17               ` Stefano Stabellini
2015-10-15 11:21                 ` Ian Campbell
2015-10-15 14:49                   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 6/8] xen: Use stable library interfaces when they are available Ian Campbell
2015-10-14 14:52   ` Stefano Stabellini
2015-10-15 14:23     ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher Ian Campbell
2015-10-14 14:22   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 8/8] xen: make it possible to build without the Xen PV domain builder Ian Campbell
2015-10-14 14:24   ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 1/5] qemu-xen-traditional: Use xentoollog as a separate library Ian Campbell
2015-10-08 11:33   ` Ian Jackson
2015-10-08 11:45     ` Ian Campbell
2015-10-08 13:53       ` Ian Jackson
2015-10-08 14:05         ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 2/5] qemu-xen-traditional: Use libxenevtchn Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 3/5] qemu-xen-traditional: Use libxengnttab Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 4/5] qemu-xen-traditional: Add libxencall to rpath-link Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 5/5] qemu-xen-traditional: Add libxenforeignmemory " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 1/5] mini-os: Include libxentoollog with libxc Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 2/5] mini-os: Include libxenevtchn " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 3/5] mini-os: Include libxengnttab " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 4/5] mini-os: Include libxencall " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 5/5] mini-os: Include libxenforeignmemory " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444227341-875-17-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).