From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>, stefano.stabellini@eu.citrix.com
Subject: [PATCH QEMU-XEN v3 4/8] xen: Switch uses of xc_map_foreign_pages into xc_map_foreign_bulk
Date: Wed, 7 Oct 2015 15:16:02 +0100 [thread overview]
Message-ID: <1444227366-1015-4-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1444226543.1410.53.camel@citrix.com>
In Xen 4.7 we are refactoring parts libxenctrl into a number of
separate libraries which will provide backward and forward API and ABI
compatiblity.
One such library will be libxenforeignmemory which provides access to
privileged foreign mappings and which will provide an interface
equivalent to xc_map_foreign_bulk.
In preparation for this switch both uses of xc_map_foreign_pages
(which both happen to be in xenfb_map_fb) to xc_map_foreign_bulk. This
simply requires allocating and passing a new err array (the same one
for both calls).
Build tested with 4.0 and 4.5.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
hw/display/xenfb.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index e3fdf33..f9442b7 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -428,6 +428,7 @@ static int xenfb_map_fb(struct XenFB *xenfb)
int n_fbdirs;
xen_pfn_t *pgmfns = NULL;
xen_pfn_t *fbmfns = NULL;
+ int *errs = NULL;
void *map, *pd;
int mode, ret = -1;
@@ -487,17 +488,18 @@ static int xenfb_map_fb(struct XenFB *xenfb)
pgmfns = g_malloc0(sizeof(xen_pfn_t) * n_fbdirs);
fbmfns = g_malloc0(sizeof(xen_pfn_t) * xenfb->fbpages);
+ errs = g_malloc0(sizeof(int) * n_fbdirs);
xenfb_copy_mfns(mode, n_fbdirs, pgmfns, pd);
- map = xc_map_foreign_pages(xen_xc, xenfb->c.xendev.dom,
- PROT_READ, pgmfns, n_fbdirs);
+ map = xc_map_foreign_bulk(xen_xc, xenfb->c.xendev.dom,
+ PROT_READ, pgmfns, errs, n_fbdirs);
if (map == NULL)
goto out;
xenfb_copy_mfns(mode, xenfb->fbpages, fbmfns, map);
munmap(map, n_fbdirs * XC_PAGE_SIZE);
- xenfb->pixels = xc_map_foreign_pages(xen_xc, xenfb->c.xendev.dom,
- PROT_READ, fbmfns, xenfb->fbpages);
+ xenfb->pixels = xc_map_foreign_bulk(xen_xc, xenfb->c.xendev.dom,
+ PROT_READ, fbmfns, errs, xenfb->fbpages);
if (xenfb->pixels == NULL)
goto out;
@@ -506,6 +508,7 @@ static int xenfb_map_fb(struct XenFB *xenfb)
out:
g_free(pgmfns);
g_free(fbmfns);
+ g_free(errs);
return ret;
}
--
2.1.4
next prev parent reply other threads:[~2015-10-07 14:16 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 14:02 [PATCH v3 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-07 14:10 ` Ian Jackson
2015-10-07 14:18 ` Ian Campbell
2015-10-07 14:28 ` [Minios-devel] " Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 01/22] tools/Rules.mk: Properly handle libraries with recursive dependencies Ian Campbell
2015-10-08 11:21 ` Ian Jackson
2015-10-08 11:38 ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 02/22] tools: Refactor "xentoollog" into its own library Ian Campbell
2015-10-07 14:42 ` Andrew Cooper
2015-10-07 14:50 ` Ian Campbell
2015-10-08 10:17 ` Ian Jackson
2015-10-08 11:23 ` Ian Jackson
2015-10-08 11:34 ` Ian Campbell
2015-10-08 13:51 ` Ian Jackson
2015-10-07 14:15 ` [PATCH XEN v3 03/22] tools/libxc: Remove osdep indirection for xc_evtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 04/22] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 05/22] tools: Arrange to check public headers for ANSI compatiblity Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 06/22] tools/libxc: Remove osdep indirection for xc_gnt{shr, tab} Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 07/22] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 08/22] tools/libxc: Remove osdep indirection for privcmd Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 09/22] tools: Refactor hypercall calling wrappers into libxencall Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 10/22] tools/libxc: drop xc_map_foreign_bulk_compat wrappers Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 11/22] tools: Remove xc_map_foreign_batch Ian Campbell
2015-10-07 15:08 ` George Dunlap
2015-10-07 15:20 ` Ian Campbell
2015-10-14 15:05 ` Ian Campbell
2015-10-14 15:11 ` George Dunlap
2015-10-07 14:15 ` [PATCH XEN v3 12/22] tools: Implement xc_map_foreign_range(s) in terms of common helper Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 13/22] tools: Refactor foreign memory mapping into libxenforeignmemory Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 14/22] tools: foreignmemory: provide xenforeignmemory_unmap Ian Campbell
2015-10-07 15:03 ` Andrew Cooper
2015-10-07 15:16 ` Ian Campbell
2015-10-07 15:20 ` Andrew Cooper
2015-10-07 15:30 ` Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 15/22] tools/libs/evtchn: Review and update doc comments Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 16/22] tools/libs: Clean up hard tabs Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 17/22] tools/libs/gnttab: Review and update doc comments Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 18/22] tools/libs/call: Update some log messages to not refer to xc Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 19/22] tools/libs/call: Avoid xc_memalign in netbsd and solaris backends Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 20/22] tools/libs/foreignmemory: Mention restrictions on fork in docs Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 21/22] tools: Update CFLAGS for qemu-xen to allow it to use new libraries Ian Campbell
2015-10-07 14:15 ` [PATCH XEN v3 22/22] HACK: Add a .config to pull all the right bits from my xenbits trees Ian Campbell
2015-10-07 14:15 ` [PATCH QEMU-XEN v3 1/8] xen: Switch to libxenevtchn interface for compat shims Ian Campbell
2015-10-07 14:36 ` Andrew Cooper
2015-10-07 14:48 ` Ian Campbell
2015-10-14 13:16 ` Stefano Stabellini
2015-10-14 13:25 ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 2/8] xen: Switch to libxengnttab " Ian Campbell
2015-10-14 13:30 ` Stefano Stabellini
2015-10-14 13:40 ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 3/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk Ian Campbell
2015-10-14 14:01 ` Stefano Stabellini
2015-10-14 14:20 ` Ian Campbell
2015-10-14 14:21 ` Stefano Stabellini
2015-10-07 14:16 ` Ian Campbell [this message]
2015-10-14 14:03 ` [PATCH QEMU-XEN v3 4/8] xen: Switch uses of xc_map_foreign_pages " Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 5/8] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API Ian Campbell
2015-10-14 14:10 ` Stefano Stabellini
2015-10-14 14:31 ` Ian Campbell
2015-10-14 15:41 ` Stefano Stabellini
2015-10-14 15:59 ` Ian Campbell
2015-10-14 16:06 ` Ian Campbell
2015-10-14 16:29 ` Stefano Stabellini
2015-10-14 16:48 ` Ian Campbell
2015-10-14 17:17 ` Stefano Stabellini
2015-10-15 11:21 ` Ian Campbell
2015-10-15 14:49 ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 6/8] xen: Use stable library interfaces when they are available Ian Campbell
2015-10-14 14:52 ` Stefano Stabellini
2015-10-15 14:23 ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 7/8] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher Ian Campbell
2015-10-14 14:22 ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN v3 8/8] xen: make it possible to build without the Xen PV domain builder Ian Campbell
2015-10-14 14:24 ` Stefano Stabellini
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 1/5] qemu-xen-traditional: Use xentoollog as a separate library Ian Campbell
2015-10-08 11:33 ` Ian Jackson
2015-10-08 11:45 ` Ian Campbell
2015-10-08 13:53 ` Ian Jackson
2015-10-08 14:05 ` Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 2/5] qemu-xen-traditional: Use libxenevtchn Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 3/5] qemu-xen-traditional: Use libxengnttab Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 4/5] qemu-xen-traditional: Add libxencall to rpath-link Ian Campbell
2015-10-07 14:16 ` [PATCH QEMU-XEN-TRADITIONAL v3 5/5] qemu-xen-traditional: Add libxenforeignmemory " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 1/5] mini-os: Include libxentoollog with libxc Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 2/5] mini-os: Include libxenevtchn " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 3/5] mini-os: Include libxengnttab " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 4/5] mini-os: Include libxencall " Ian Campbell
2015-10-07 14:16 ` [PATCH MINI-OS v3 5/5] mini-os: Include libxenforeignmemory " Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444227366-1015-4-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).