From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH XEN v3 02/22] tools: Refactor "xentoollog"
 into its own library
Date: Wed, 7 Oct 2015 15:50:22 +0100
Message-ID: <1444229422.1410.61.camel@citrix.com>
References: <1444226543.1410.53.camel@citrix.com>
	<1444227341-875-2-git-send-email-ian.campbell@citrix.com>
	<56152F48.5040403@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56152F48.5040403@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-10-07 at 15:42 +0100, Andrew Cooper wrote:

> > +.PHONY: install
> > +install: build
> > +	$(INSTALL_DIR) $(DESTDIR)$(libdir)
> > +	$(INSTALL_DIR) $(DESTDIR)$(includedir)
> > +	$(INSTALL_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR)
> > $(DESTDIR)$(libdir)
> > +	$(INSTALL_DATA) libxentoollog.a $(DESTDIR)$(libdir)
> > +	$(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR).$(MINOR)
> > $(DESTDIR)$(libdir)/libxentoollog.so.$(MAJOR)
> > +	$(SYMLINK_SHLIB) libxentoollog.so.$(MAJOR)
> > $(DESTDIR)$(libdir)/libxentoollog.so
> 
> Installation of all .so's needs to be conditional on $(nosharedlibs) to
> match the condition in the build rule.

This isn't true of any of the existing in tree things (e.g. the existing
libxenctrl Makefile, the xenstore one etc).

I think because the nosharedlibs mode is specifically for stubdom (and
rumpkernel?) and we do not (yet?) support install for builds of those
types.

Ian.