From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v1 4/4] libxl: info: Display build_id of the hypervisor. Date: Fri, 9 Oct 2015 10:36:45 +0100 Message-ID: <1444383405.1410.317.camel@citrix.com> References: <1444359390-14153-1-git-send-email-konrad.wilk@oracle.com> <1444359390-14153-5-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZkU6c-0001Nm-EH for xen-devel@lists.xenproject.org; Fri, 09 Oct 2015 09:36:50 +0000 In-Reply-To: <1444359390-14153-5-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, andrew.cooper3@citrix.com, mpohlack@amazon.de, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On Thu, 2015-10-08 at 22:56 -0400, Konrad Rzeszutek Wilk wrote: > If the hypervisor is built with we will display it. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > tools/libxl/libxl.c | 16 ++++++++++++++++ > tools/libxl/libxl_types.idl | 1 + > tools/libxl/xl_cmdimpl.c | 1 + > 3 files changed, 18 insertions(+) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index efa6462..f9af78c 100644 > --- a/tools/libxl/libxl.c > +++ b/tools/libxl/libxl.c > @@ -5249,6 +5249,7 @@ libxl_numainfo *libxl_get_numainfo(libxl_ctx *ctx, > int *nr) > return ret; > } > > +#define BUILD_ID_LEN 1024 /* Same size as xen_commandline. */ This either needs to be well defined in the hypercall ABI or the code here needs to cope with expanding the buffer on ENOBUFS and trying again. Ian.