From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH v3 2/3] Testing cpupools: recipe for
 it and job definition
Date: Fri, 9 Oct 2015 15:34:46 +0100
Message-ID: <1444401286.1410.401.camel@citrix.com>
References: <20151003003554.12311.97039.stgit@Solace.station>
	<20151003003929.12311.52265.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=717dc9c5a=Ian.Campbell@citrix.com>)
	id 1ZkYl0-00063j-Vp
	for xen-devel@lists.xenproject.org; Fri, 09 Oct 2015 14:34:51 +0000
In-Reply-To: <20151003003929.12311.52265.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Sat, 2015-10-03 at 02:39 +0200, Dario Faggioli wrote:
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>

This looks correct to me as it stands, but I think it will be impacted by
the changes relating to host flags for numbers of cpus etc.

> ---
> Changes from v2:
>  * restrict test generation to xl only.
> 
> Changes from v1:
>  * added invocation to ts-guest-stop in the recipe to kill
>    leak-check complaints (which went unnoticed during v1
>    testing, sorry)
>  * moved the test before the "ARM cutoff", and remove the
>    per-arch filtering, so that the test can run on ARM
>    hardware too
> ---
>  make-flight |   12 ++++++++++++
>  sg-run-job  |    7 +++++++
>  2 files changed, 19 insertions(+)
> 
> diff --git a/make-flight b/make-flight
> index 8c75a9c..d27a02c 100755
> --- a/make-flight
> +++ b/make-flight
> @@ -373,6 +373,16 @@ do_multivcpu_tests () {
>                      $debian_runvars all_hostflags=$most_hostflags
>  }
>  
> +do_cpupools_tests () {
> +  if [ x$toolstack != xxl -a $xenarch != $dom0arch ]; then
> +    return
> +  fi
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-xl-cpupools            \
> +                    test-cpupools xl $xenarch $dom0arch               \
> +                    $debian_runvars all_hostflags=$most_hostflags
> +}
> +
>  do_passthrough_tests () {
>    if [ $xenarch != amd64 -o $dom0arch != amd64 -o "$kern" != "" ]; then
>      return
> @@ -498,6 +508,8 @@ test_matrix_do_one () {
>    do_rtds_tests
>    do_credit2_tests
>  
> +  do_cpupools_tests
> +
>    # No further arm tests at the moment
>    if [ $dom0arch = armhf ]; then
>        return
> diff --git a/sg-run-job b/sg-run-job
> index 66145b8..ea48a03 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -296,6 +296,13 @@ proc run-job/test-debianhvm {} {
>      test-guest debianhvm
>  }
>  
> +proc need-hosts/test-cpupools {} { return host }
> +proc run-job/test-cpupools {} {
> +    install-guest-debian
> +    run-ts . = ts-cpupools + host debian
> +    run-ts . = ts-guest-stop + host debian
> +}
> +
>  proc setup-test-pair {} {
>      run-ts . =              ts-debian-install      dst_host
>      run-ts . =              ts-debian-fixup        dst_host          +
> debian
>