xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Feng Wu <feng.wu@intel.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>, Kevin Tian <kevin.tian@intel.com>,
	feng.wu@intel.com, Jan Beulich <jbeulich@suse.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v8 07/17] vmx: Initialize VT-d Posted-Interrupts Descriptor
Date: Mon, 12 Oct 2015 16:54:53 +0800	[thread overview]
Message-ID: <1444640103-4685-8-git-send-email-feng.wu@intel.com> (raw)
In-Reply-To: <1444640103-4685-1-git-send-email-feng.wu@intel.com>

This patch initializes the VT-d Posted-interrupt Descriptor.

CC: Kevin Tian <kevin.tian@intel.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Feng Wu <feng.wu@intel.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
v7:
- Add comments to function 'pi_desc_init' to clarify why we
  update the posted-interrupt descriptor in non-atomical way
  in it.

v3:
- Move pi_desc_init() to xen/arch/x86/hvm/vmx/vmcs.c
- Remove the 'inline' flag of pi_desc_init()

 xen/arch/x86/hvm/vmx/vmcs.c       | 22 ++++++++++++++++++++++
 xen/include/asm-x86/hvm/vmx/vmx.h |  2 ++
 2 files changed, 24 insertions(+)

diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index a0a97e7..5f67797 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -39,6 +39,7 @@
 #include <asm/flushtlb.h>
 #include <asm/shadow.h>
 #include <asm/tboot.h>
+#include <asm/apic.h>
 
 static bool_t __read_mostly opt_vpid_enabled = 1;
 boolean_param("vpid", opt_vpid_enabled);
@@ -951,6 +952,24 @@ void virtual_vmcs_vmwrite(void *vvmcs, u32 vmcs_encoding, u64 val)
     virtual_vmcs_exit(vvmcs);
 }
 
+/*
+ * This function is only called in a vCPU's initialization phase,
+ * so we can update the posted-interrupt descriptor in non-atomic way.
+ */
+static void pi_desc_init(struct vcpu *v)
+{
+    uint32_t dest;
+
+    v->arch.hvm_vmx.pi_desc.nv = posted_intr_vector;
+
+    dest = cpu_physical_id(v->processor);
+
+    if ( x2apic_enabled )
+        v->arch.hvm_vmx.pi_desc.ndst = dest;
+    else
+        v->arch.hvm_vmx.pi_desc.ndst = MASK_INSR(dest, PI_xAPIC_NDST_MASK);
+}
+
 static int construct_vmcs(struct vcpu *v)
 {
     struct domain *d = v->domain;
@@ -1089,6 +1108,9 @@ static int construct_vmcs(struct vcpu *v)
 
     if ( cpu_has_vmx_posted_intr_processing )
     {
+        if ( iommu_intpost )
+            pi_desc_init(v);
+
         __vmwrite(PI_DESC_ADDR, virt_to_maddr(&v->arch.hvm_vmx.pi_desc));
         __vmwrite(POSTED_INTR_NOTIFICATION_VECTOR, posted_intr_vector);
     }
diff --git a/xen/include/asm-x86/hvm/vmx/vmx.h b/xen/include/asm-x86/hvm/vmx/vmx.h
index 8d91110..70b254f 100644
--- a/xen/include/asm-x86/hvm/vmx/vmx.h
+++ b/xen/include/asm-x86/hvm/vmx/vmx.h
@@ -88,6 +88,8 @@ typedef enum {
 #define EPT_EMT_WB              6
 #define EPT_EMT_RSV2            7
 
+#define PI_xAPIC_NDST_MASK      0xFF00
+
 void vmx_asm_vmexit_handler(struct cpu_user_regs);
 void vmx_asm_do_vmentry(void);
 void vmx_intr_assist(void);
-- 
2.1.0

  parent reply	other threads:[~2015-10-12  8:54 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12  8:54 [PATCH v8 00/17] Add VT-d Posted-Interrupts support Feng Wu
2015-10-12  8:54 ` [PATCH v8 01/17] VT-d Posted-intterrupt (PI) design Feng Wu
2015-10-12 10:41   ` Andrew Cooper
2015-10-13  0:53     ` Wu, Feng
2015-10-29 15:56   ` Dario Faggioli
2015-10-12  8:54 ` [PATCH v8 02/17] Add cmpxchg16b support for x86-64 Feng Wu
2015-10-13 15:29   ` Jan Beulich
2015-10-14  5:57     ` Wu, Feng
2015-10-14  9:05       ` Jan Beulich
2015-10-14  9:29         ` Wu, Feng
2015-10-14  9:45           ` Jan Beulich
2015-10-14 10:03             ` Wu, Feng
2015-10-14 10:21               ` Jan Beulich
2015-10-14 10:25                 ` Wu, Feng
2015-10-12  8:54 ` [PATCH v8 03/17] iommu: Add iommu_intpost to control VT-d Posted-Interrupts feature Feng Wu
2015-10-12  8:54 ` [PATCH v8 04/17] vt-d: VT-d Posted-Interrupts feature detection Feng Wu
2015-10-12  8:54 ` [PATCH v8 05/17] vmx: Extend struct pi_desc to support VT-d Posted-Interrupts Feng Wu
2015-10-12  8:54 ` [PATCH v8 06/17] vmx: Add some helper functions for Posted-Interrupts Feng Wu
2015-10-12  8:54 ` Feng Wu [this message]
2015-10-12  8:54 ` [PATCH v8 08/17] vmx: Suppress posting interrupts when 'SN' is set Feng Wu
2015-10-12  8:54 ` [PATCH v8 09/17] VT-d: Remove pointless casts Feng Wu
2015-10-12  8:54 ` [PATCH v8 10/17] vt-d: Extend struct iremap_entry to support VT-d Posted-Interrupts Feng Wu
2015-10-12  8:54 ` [PATCH v8 11/17] vt-d: Add API to update IRTE when VT-d PI is used Feng Wu
2015-10-12  8:54 ` [PATCH v8 12/17] x86: move some APIC related macros to apicdef.h Feng Wu
2015-10-12  8:54 ` [PATCH v8 13/17] Update IRTE according to guest interrupt config changes Feng Wu
2015-10-12  8:55 ` [PATCH v8 14/17] vmx: Properly handle notification event when vCPU is running Feng Wu
2015-10-12  8:55 ` [PATCH v8 15/17] vmx: VT-d posted-interrupt core logic handling Feng Wu
2015-10-26 14:39   ` Dario Faggioli
2015-10-27  5:19     ` Wu, Feng
2015-10-27  9:51       ` Jan Beulich
2015-10-28  1:50         ` Dario Faggioli
2015-10-28  2:58         ` Wu, Feng
2015-10-28  9:03           ` Jan Beulich
2015-10-28 16:36             ` Dario Faggioli
2015-10-29  5:39               ` Wu, Feng
2015-10-29  9:26                 ` Dario Faggioli
2015-10-29 14:07                   ` Wu, Feng
2015-10-27 12:16       ` Dario Faggioli
2015-10-28  2:40         ` Wu, Feng
2015-10-27 12:22   ` Dario Faggioli
2015-10-12  8:55 ` [PATCH v8 16/17] VT-d: Dump the posted format IRTE Feng Wu
2015-10-12  8:55 ` [PATCH v8 17/17] Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-10-23  2:12 ` [PATCH v8 00/17] Add VT-d Posted-Interrupts support Wu, Feng
2015-10-23  8:13   ` Jan Beulich
2015-10-23  8:35     ` Wu, Feng
2015-10-23  8:46       ` Dario Faggioli
2015-10-23  8:52         ` Wu, Feng
2015-10-29 10:51 ` Dario Faggioli
2015-10-29 14:05   ` Wu, Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444640103-4685-8-git-send-email-feng.wu@intel.com \
    --to=feng.wu@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).