From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xen.org, Ian.Campbell@citrix.com,
ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com,
wei.liu2@citrix.com, roger.pau@citrix.com
Cc: Juergen Gross <jgross@suse.com>
Subject: [PATCH v3 6/9] libxc: create unmapped initrd in domain builder if supported
Date: Tue, 13 Oct 2015 15:11:15 +0200 [thread overview]
Message-ID: <1444741878-16610-7-git-send-email-jgross@suse.com> (raw)
In-Reply-To: <1444741878-16610-1-git-send-email-jgross@suse.com>
In case the kernel of a new pv-domU indicates it is supporting an
unmapped initrd, don't waste precious virtual space for the initrd,
but allocate only guest physical memory for it.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/libxc/include/xc_dom.h | 5 +++++
tools/libxc/xc_dom_core.c | 19 +++++++++++++++++--
tools/libxc/xc_dom_x86.c | 8 ++++----
3 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
index b0120a6..fa772a9 100644
--- a/tools/libxc/include/xc_dom.h
+++ b/tools/libxc/include/xc_dom.h
@@ -94,6 +94,11 @@ struct xc_dom_image {
xen_pfn_t pfn_alloc_end;
xen_vaddr_t virt_alloc_end;
xen_vaddr_t bsd_symtab_start;
+
+ /* initrd parameters as specified in start_info page */
+ unsigned long initrd_start;
+ unsigned long initrd_len;
+
unsigned int alloc_bootstack;
xen_vaddr_t virt_pgtab_end;
diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c
index 8e1e17f..15e9fa3 100644
--- a/tools/libxc/xc_dom_core.c
+++ b/tools/libxc/xc_dom_core.c
@@ -1041,6 +1041,7 @@ static int xc_dom_build_ramdisk(struct xc_dom_image *dom)
int xc_dom_build_image(struct xc_dom_image *dom)
{
unsigned int page_size;
+ bool unmapped_initrd;
DOMPRINTF_CALLED(dom->xch);
@@ -1064,11 +1065,15 @@ int xc_dom_build_image(struct xc_dom_image *dom)
if ( dom->kernel_loader->loader(dom) != 0 )
goto err;
- /* load ramdisk */
- if ( dom->ramdisk_blob )
+ /* Load ramdisk if initial mapping required. */
+ unmapped_initrd = dom->parms.unmapped_initrd && !dom->ramdisk_seg.vstart;
+
+ if ( dom->ramdisk_blob && !unmapped_initrd )
{
if ( xc_dom_build_ramdisk(dom) != 0 )
goto err;
+ dom->initrd_start = dom->ramdisk_seg.vstart;
+ dom->initrd_len = dom->ramdisk_seg.vend - dom->ramdisk_seg.vstart;
}
/* load devicetree */
@@ -1106,6 +1111,16 @@ int xc_dom_build_image(struct xc_dom_image *dom)
if ( dom->virt_pgtab_end && xc_dom_alloc_pad(dom, dom->virt_pgtab_end) )
return -1;
+ /* Load ramdisk if no initial mapping required. */
+ if ( dom->ramdisk_blob && unmapped_initrd )
+ {
+ if ( xc_dom_build_ramdisk(dom) != 0 )
+ goto err;
+ dom->flags |= SIF_MOD_START_PFN;
+ dom->initrd_start = dom->ramdisk_seg.pfn;
+ dom->initrd_len = page_size * dom->ramdisk_seg.pages;
+ }
+
return 0;
err:
diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
index 60d54b3..7e2f1c5 100644
--- a/tools/libxc/xc_dom_x86.c
+++ b/tools/libxc/xc_dom_x86.c
@@ -663,8 +663,8 @@ static int start_info_x86_32(struct xc_dom_image *dom)
if ( dom->ramdisk_blob )
{
- start_info->mod_start = dom->ramdisk_seg.vstart;
- start_info->mod_len = dom->ramdisk_seg.vend - dom->ramdisk_seg.vstart;
+ start_info->mod_start = dom->initrd_start;
+ start_info->mod_len = dom->initrd_len;
}
if ( dom->cmdline )
@@ -710,8 +710,8 @@ static int start_info_x86_64(struct xc_dom_image *dom)
if ( dom->ramdisk_blob )
{
- start_info->mod_start = dom->ramdisk_seg.vstart;
- start_info->mod_len = dom->ramdisk_seg.vend - dom->ramdisk_seg.vstart;
+ start_info->mod_start = dom->initrd_start;
+ start_info->mod_len = dom->initrd_len;
}
if ( dom->cmdline )
--
2.1.4
next prev parent reply other threads:[~2015-10-13 13:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 13:11 [PATCH v3 0/9] libxc: support building large pv-domains Juergen Gross
2015-10-13 13:11 ` [PATCH v3 1/9] libxc: reorganize domain builder guest memory allocator Juergen Gross
2015-10-28 15:32 ` Wei Liu
2015-10-28 15:51 ` Juergen Gross
2015-10-28 16:21 ` Wei Liu
2015-10-28 17:05 ` Juergen Gross
2015-10-13 13:11 ` [PATCH v3 2/9] xen: add generic flag to elf_dom_parms indicating support of unmapped initrd Juergen Gross
2015-10-28 15:33 ` Wei Liu
2015-10-28 15:49 ` Jan Beulich
2015-10-13 13:11 ` [PATCH v3 3/9] libxc: rename domain builder count_pgtables to alloc_pgtables Juergen Gross
2015-10-28 15:34 ` Wei Liu
2015-10-13 13:11 ` [PATCH v3 4/9] libxc: introduce domain builder architecture specific data Juergen Gross
2015-10-28 15:37 ` Wei Liu
2015-10-13 13:11 ` [PATCH v3 5/9] libxc: use domain builder architecture private data for x86 pv domains Juergen Gross
2015-10-28 15:38 ` Wei Liu
2015-10-13 13:11 ` Juergen Gross [this message]
2015-10-28 16:11 ` [PATCH v3 6/9] libxc: create unmapped initrd in domain builder if supported Wei Liu
2015-10-28 17:07 ` Juergen Gross
2015-10-13 13:11 ` [PATCH v3 7/9] libxc: split p2m allocation in domain builder from other magic pages Juergen Gross
2015-10-28 16:11 ` Wei Liu
2015-10-13 13:11 ` [PATCH v3 8/9] libxc: rework of domain builder's page table handler Juergen Gross
2015-10-29 12:48 ` Wei Liu
2015-10-29 13:18 ` Juergen Gross
2015-10-29 14:02 ` Wei Liu
2015-10-29 14:13 ` Juergen Gross
2015-10-29 15:03 ` Wei Liu
2015-10-29 15:34 ` Juergen Gross
2015-10-13 13:11 ` [PATCH v3 9/9] libxc: create p2m list outside of kernel mapping if supported Juergen Gross
2015-10-29 13:07 ` Wei Liu
2015-10-29 13:19 ` Juergen Gross
2015-10-26 11:15 ` [PATCH v3 0/9] libxc: support building large pv-domains Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444741878-16610-7-git-send-email-jgross@suse.com \
--to=jgross@suse.com \
--cc=Ian.Campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).