From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP Date: Tue, 13 Oct 2015 17:23:29 +0100 Message-ID: <1444753409.23192.111.camel@citrix.com> References: <1444726426-10567-1-git-send-email-he.chen@linux.intel.com> <1444726426-10567-4-git-send-email-he.chen@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zm2MP-00068m-W1 for xen-devel@lists.xenproject.org; Tue, 13 Oct 2015 16:23:34 +0000 In-Reply-To: <1444726426-10567-4-git-send-email-he.chen@linux.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: He Chen , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, jbeulich@suse.com, chao.p.peng@linux.intel.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2015-10-13 at 16:53 +0800, He Chen wrote: > @@ -8445,29 +8447,46 @@ out: > return rc; > } > > -static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t > socketid) > +static void psr_cat_print_one_domain_cbm_type(uint32_t domid, uint32_t > socketid, > + libxl_psr_cbm_type type) > { > - char *domain_name; > uint64_t cbm; > + if (!libxl_psr_cat_get_cbm(ctx, domid, type, socketid, &cbm)) > + printf("%#16"PRIx64, cbm); > + else > + printf("%16s", "error"); Coding style is 4 space indentation, here you appear to have 8 for the first level and 4 for the second level of indentation. With that fixed: Acked-by: Ian Campbell