From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH QEMU-XEN v3 2/8] xen: Switch to libxengnttab
 interface for compat shims.
Date: Wed, 14 Oct 2015 14:40:06 +0100
Message-ID: <1444830006.23192.191.camel@citrix.com>
References: <1444226543.1410.53.camel@citrix.com>
	<1444227366-1015-2-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1510141421360.27957@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1510141421360.27957@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-10-14 at 14:30 +0100, Stefano Stabellini wrote:
> @@ -71,11 +71,29 @@ static inline int xenevtchn_close(xenevtchn_handle
> > *h)
> >  #define xenevtchn_unmask(h,p) xc_evtchn_unmask(*h,p)
> >  #define xenevtchn_unbind(h,p) xc_evtchn_unmask(*h,p)
> >  
> > -static inline XenGnttab xen_xc_gnttab_open(void *logger,
> > -                                           unsigned int open_flags)
> > +static inline xengnttab_handle *xengnttab_open(void *logger,
> > +					       unsigned int
> > open_flags)
> >  {
> > -    return xc_gnttab_open();
> > +    int *h = malloc(sizeof h);
>                        ^
>                        sizeof (*h)

FYI I've done this mistake in all the patches, and will fix all in one go,
so you can skip this for the remainder.

> > +    if (!h)
> > +	return NULL;
> 
> indentation

Probably this too, but I will check them all so no need to keep checking.

Ian.