From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH QEMU-XEN v3 5/8] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API. Date: Wed, 14 Oct 2015 17:48:44 +0100 Message-ID: <1444841324.1607.4.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> <1444227366-1015-5-git-send-email-ian.campbell@citrix.com> <1444833094.23192.217.camel@citrix.com> <1444838399.23192.228.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-10-14 at 17:29 +0100, Stefano Stabellini wrote: > > Obviously the call to xen_be_unbind_evtchn is not useful as is, but I do > > wonder where the evtchn which the primary console must have somewhere > > actually is then... > > Actually I think that xen_be_unbind_evtchn might be useful too, I think > that is the primary console evtchn. I wonder what specific bug I was > trying to fix when I introduced that if (!xendev->dev) check. I misread xen_be_unbind_evtchn(&con->xendev) as taking xendev->dev instead, which would be NULL and hence pointless... But given that it isn't then yes it seems like it would be worth calling. Is it not the case that &con->xendev == xendev here, leading to another potential cleanup? Ian.