From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH QEMU-XEN v3 6/8] xen: Use stable library interfaces when they are available. Date: Thu, 15 Oct 2015 15:23:22 +0100 Message-ID: <1444919002.1607.92.camel@citrix.com> References: <1444226543.1410.53.camel@citrix.com> <1444227366-1015-6-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2015-10-14 at 15:52 +0100, Stefano Stabellini wrote: > > + # These libraries were all introduced in the same release, to > > + # simplify things we therefore assume its either all or nothing and > > + # treat any other mix as an error > > + case $xenevtchn$xengnttab$xenforeignmemory in > > + yesyesyes) xenstablelibs=yes;; > > + nonono) xenstablelibs=no;; > > + *) error_exit "Inconsistent set of xen libraries found" > > + ;; > > + esac > > I would remove all this and introduce a xen_stable_libs for the Xen 4.7 > and beyond case: > > xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn" This and all the consequences which followed make sense and should simplify a bunch of stuff, so will do. Ian.