From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 2/5] raisin: Detect systemd
Date: Fri, 16 Oct 2015 15:02:02 +0100
Message-ID: <1445004122.12442.83.camel@citrix.com>
References: <1444839707-2339-1-git-send-email-george.dunlap@eu.citrix.com>
	<1444839707-2339-3-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1510161438131.27957@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1510161438131.27957@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-10-16 at 14:39 +0100, Stefano Stabellini wrote:
> On Wed, 14 Oct 2015, George Dunlap wrote:
> > Add systemd development libraries if we detect systemd present on the
> > system
> > 
> > Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> Please use spaces for indentation
> 
>     
> >  components/xen | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/components/xen b/components/xen
> > index 090cceb..93ed288 100644
> > --- a/components/xen
> > +++ b/components/xen
> > @@ -8,6 +8,11 @@ function xen_check_package() {
> >      local DEP_Debian_common="build-essential python-dev gettext uuid
> > -dev   \
> >               libncurses5-dev libyajl-dev libaio-dev pkg-config
> > libglib2.0-dev  \
> >               libssl-dev libpixman-1-dev bridge-utils wget"
> > +
> > +    if [[ -e "/usr/lib/systemd" ]]
> 
> I don't know much about systemd but isn't there a better way to detect
> systemd? Check if it is running for example?

You might want to build with systemd support even if systemd isn't actually
the current init system the system was booted with?

> 
> 
> > +    then
> > +	DEP_Debian_common="$DEP_Debian_common libsystemd-daemon-dev"
> > +    fi
> >      local DEP_Debian_x86_32="$DEP_Debian_common bcc iasl bin86
> > texinfo"
> >      local DEP_Debian_x86_64="$DEP_Debian_x86_32 libc6-dev-i386"
> >      local DEP_Debian_arm32="$DEP_Debian_common libfdt-dev"
> > @@ -16,6 +21,10 @@ function xen_check_package() {
> >      local DEP_Fedora_common="make gcc python-devel gettext libuuid
> > -devel   \
> >               ncurses-devel glib2-devel libaio-devel openssl-devel yajl
> > -devel   \
> >               patch pixman-devel glibc-devel bridge-utils grub2 wget
> > tar bzip2"
> > +    if [[ -e "/usr/lib/systemd" ]]
> > +    then
> > +	DEP_Fedora_common="$DEP_Fedora_common systemd-devel|systemd
> > -container-devel"
> > +    fi
> >      local DEP_Fedora_x86_32="$DEP_Fedora_common dev86 acpica-tools
> > texinfo"
> >      local DEP_Fedora_x86_64="$DEP_Fedora_x86_32 glibc-devel.i686"
> >  
> > @@ -23,6 +32,7 @@ function xen_check_package() {
> >      local DEP_CentOS_x86_32="$DEP_CentOS_common dev86 texinfo iasl"
> >      local DEP_CentOS_x86_64="$DEP_CentOS_x86_32 glibc-devel.i686"
> >  
> > +
> 
> spurious change
> 
> 
> >      verbose_echo Checking Xen dependencies
> >      eval check-package \$DEP_"$DISTRO"_"$RAISIN_ARCH"
> >  }