From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH XEN v4 15/23] foreignmemory: use size_t for size arguments.
Date: Wed, 21 Oct 2015 16:23:22 +0100 [thread overview]
Message-ID: <1445441010-25776-16-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1445441010-25776-1-git-send-email-ian.campbell@citrix.com>
Surprisingly it appears no callers need updating.
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
v4: New patch
---
tools/libs/foreignmemory/compat.c | 2 +-
tools/libs/foreignmemory/freebsd.c | 4 ++--
.../libs/foreignmemory/include/xenforeignmemory.h | 4 ++--
tools/libs/foreignmemory/linux.c | 25 +++++++++++-----------
tools/libs/foreignmemory/minios.c | 6 +++---
tools/libs/foreignmemory/netbsd.c | 2 +-
tools/libs/foreignmemory/solaris.c | 2 +-
7 files changed, 23 insertions(+), 22 deletions(-)
diff --git a/tools/libs/foreignmemory/compat.c b/tools/libs/foreignmemory/compat.c
index df9702e..46c4b55 100644
--- a/tools/libs/foreignmemory/compat.c
+++ b/tools/libs/foreignmemory/compat.c
@@ -23,7 +23,7 @@
void *xc_map_foreign_bulk(xenforeignmem_handle *fmem,
uint32_t dom, int prot,
- const xen_pfn_t *arr, int *err, unsigned int num)
+ const xen_pfn_t *arr, int *err, size_t num)
{
xen_pfn_t *pfn;
unsigned int i;
diff --git a/tools/libs/foreignmemory/freebsd.c b/tools/libs/foreignmemory/freebsd.c
index f9e74fa..0d71713 100644
--- a/tools/libs/foreignmemory/freebsd.c
+++ b/tools/libs/foreignmemory/freebsd.c
@@ -85,7 +85,7 @@ int osdep_xenforeignmemory_close(xenforeignmemory_handle *fmem)
void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
uint32_t dom, int prot,
const xen_pfn_t *arr, int *err,
- unsigned int num)
+ size_t num)
{
int fd = fmem->fd;
privcmd_mmapbatch_t ioctlx;
@@ -119,7 +119,7 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
}
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num)
+ void *addr, size_t num)
{
return munmap(addr, num << PAGE_SHIFT);
}
diff --git a/tools/libs/foreignmemory/include/xenforeignmemory.h b/tools/libs/foreignmemory/include/xenforeignmemory.h
index 1bcdf6a..99ec883 100644
--- a/tools/libs/foreignmemory/include/xenforeignmemory.h
+++ b/tools/libs/foreignmemory/include/xenforeignmemory.h
@@ -56,10 +56,10 @@ int xenforeignmemory_close(xenforeignmemory_handle *xmem);
*/
void *xenforeignmemory_map(xenforeignmemory_handle *fmem, uint32_t dom,
int prot, const xen_pfn_t *arr, int *err,
- unsigned int num);
+ size_t pages);
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num);
+ void *addr, size_t pages);
#endif
diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c
index 86a5a97..3c08679 100644
--- a/tools/libs/foreignmemory/linux.c
+++ b/tools/libs/foreignmemory/linux.c
@@ -109,10 +109,11 @@ static int map_foreign_batch_single(int fd, uint32_t dom,
* This will keep the request ring full and avoids delays.
*/
static int retry_paged(int fd, uint32_t dom, void *addr,
- const xen_pfn_t *arr, int *err, unsigned int num)
+ const xen_pfn_t *arr, int *err, size_t num)
{
privcmd_mmapbatch_v2_t ioctlx;
- int rc, paged = 0, i = 0;
+ int rc, paged = 0;
+ size_t i = 0;
do
{
@@ -128,7 +129,7 @@ static int retry_paged(int fd, uint32_t dom, void *addr,
/* At least one gfn is still in paging state */
ioctlx.num = 1;
ioctlx.dom = dom;
- ioctlx.addr = (unsigned long)addr + ((unsigned long)i<<PAGE_SHIFT);
+ ioctlx.addr = (unsigned long)addr + (i<<PAGE_SHIFT);
ioctlx.arr = arr + i;
ioctlx.err = err + i;
@@ -153,16 +154,16 @@ out:
}
void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
- uint32_t dom, int prot,
- const xen_pfn_t *arr, int *err, unsigned int num)
+ uint32_t dom, int prot,
+ const xen_pfn_t *arr, int *err, size_t num)
{
int fd = fmem->fd;
privcmd_mmapbatch_v2_t ioctlx;
void *addr;
- unsigned int i;
+ size_t i;
int rc;
- addr = mmap(NULL, (unsigned long)num << PAGE_SHIFT, prot, MAP_SHARED,
+ addr = mmap(NULL, num << PAGE_SHIFT, prot, MAP_SHARED,
fd, 0);
if ( addr == MAP_FAILED )
{
@@ -206,7 +207,7 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
if ( pfn == MAP_FAILED )
{
PERROR("mmap of pfn array failed");
- (void)munmap(addr, (unsigned long)num << PAGE_SHIFT);
+ (void)munmap(addr, num << PAGE_SHIFT);
return NULL;
}
}
@@ -239,7 +240,7 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
continue;
}
rc = map_foreign_batch_single(fd, dom, pfn + i,
- (unsigned long)addr + ((unsigned long)i<<PAGE_SHIFT));
+ (unsigned long)addr + (i<<PAGE_SHIFT));
if ( rc < 0 )
{
rc = -errno;
@@ -268,7 +269,7 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
int saved_errno = errno;
PERROR("ioctl failed");
- (void)munmap(addr, (unsigned long)num << PAGE_SHIFT);
+ (void)munmap(addr, num << PAGE_SHIFT);
errno = saved_errno;
return NULL;
}
@@ -277,9 +278,9 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
}
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num)
+ void *addr, size_t num)
{
- return munmap(addr, (unsigned long)num << PAGE_SHIFT);
+ return munmap(addr, num << PAGE_SHIFT);
}
/*
diff --git a/tools/libs/foreignmemory/minios.c b/tools/libs/foreignmemory/minios.c
index dbb152f..3d3c711 100644
--- a/tools/libs/foreignmemory/minios.c
+++ b/tools/libs/foreignmemory/minios.c
@@ -40,8 +40,8 @@ int osdep_xenforeignmemory_close(xenforeignmemory_handle *fmem)
}
void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
- uint32_t dom, int prot,
- const xen_pfn_t *arr, int *err, unsigned int num)
+ uint32_t dom, int prot,
+ const xen_pfn_t *arr, int *err, size_t num)
{
unsigned long pt_prot = 0;
if (prot & PROT_READ)
@@ -52,7 +52,7 @@ void *xenforeignmemory_map(xenforeignmemory_handle *fmem,
}
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num)
+ void *addr, size_t num)
{
return munmap(addr, num << PAGE_SHIFT);
}
diff --git a/tools/libs/foreignmemory/netbsd.c b/tools/libs/foreignmemory/netbsd.c
index 4d68b52..747d5b4 100644
--- a/tools/libs/foreignmemory/netbsd.c
+++ b/tools/libs/foreignmemory/netbsd.c
@@ -95,7 +95,7 @@ void *compat_mapforeign_batch(xenforeignmem_handle *fmem, uint32_t dom,
}
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num)
+ void *addr, size_t num)
{
return munmap(addr, num*XC_PAGE_SIZE);
}
diff --git a/tools/libs/foreignmemory/solaris.c b/tools/libs/foreignmemory/solaris.c
index 3f8e705..359e664 100644
--- a/tools/libs/foreignmemory/solaris.c
+++ b/tools/libs/foreignmemory/solaris.c
@@ -94,7 +94,7 @@ void *compat_mapforeign_batch(xenforeignmem_handle *fmem, uint32_t dom,
}
int xenforeignmemory_unmap(xenforeignmemory_handle *fmem,
- void *addr, unsigned int num)
+ void *addr, size_t num)
{
return munmap(addr, num*XC_PAGE_SIZE);
}
--
2.1.4
next prev parent reply other threads:[~2015-10-21 15:23 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 15:22 [PATCH v4 0/<VARIOUS>] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-21 15:23 ` [PATCH XEN v4 00/23] " Ian Campbell
2015-10-21 15:23 ` [PATCH XEN v4 01/23] tools/Rules.mk: Properly handle libraries with recursive dependencies Ian Campbell
2015-10-29 16:27 ` Wei Liu
2015-11-02 14:20 ` Ian Campbell
2015-10-21 15:23 ` [PATCH XEN v4 02/23] tools: Refactor "xentoollog" into its own library Ian Campbell
2015-10-29 16:27 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 03/23] tools/libxc: Remove osdep indirection for xc_evtchn Ian Campbell
2015-10-29 16:27 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 04/23] tools: Refactor /dev/xen/evtchn wrappers into libxenevtchn Ian Campbell
2015-10-29 16:27 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 05/23] tools: Arrange to check public headers for ANSI compatiblity Ian Campbell
2015-10-29 16:27 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 06/23] tools/libxc: Remove osdep indirection for xc_gnt{shr, tab} Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 07/23] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-11-04 16:08 ` Ian Campbell
2015-10-21 15:23 ` [PATCH XEN v4 08/23] tools/libxc: Remove osdep indirection for privcmd Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 09/23] tools: Refactor hypercall calling wrappers into libxencall Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 10/23] tools/libxc: drop xc_map_foreign_bulk_compat wrappers Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 11/23] tools: Remove xc_map_foreign_batch Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 12/23] tools: Implement xc_map_foreign_range(s) in terms of common helper Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 13/23] tools: Refactor foreign memory mapping into libxenforeignmemory Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 14/23] tools: foreignmemory: provide xenforeignmemory_unmap Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` Ian Campbell [this message]
2015-10-29 16:28 ` [PATCH XEN v4 15/23] foreignmemory: use size_t for size arguments Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 16/23] tools/libs/evtchn: Review and update doc comments Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 17/23] tools/libs: Clean up hard tabs Ian Campbell
2015-10-29 16:28 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 18/23] tools/libs/gnttab: Review and update doc comments Ian Campbell
2015-10-29 16:29 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 19/23] tools/libs/call: Update some log messages to not refer to xc Ian Campbell
2015-10-29 16:29 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 20/23] tools/libs/call: Avoid xc_memalign in netbsd and solaris backends Ian Campbell
2015-10-29 16:29 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 21/23] tools/libs/foreignmemory: Mention restrictions on fork in docs Ian Campbell
2015-10-29 16:29 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 22/23] tools: Update CFLAGS for qemu-xen to allow it to use new libraries Ian Campbell
2015-10-29 16:29 ` Wei Liu
2015-10-21 15:23 ` [PATCH XEN v4 23/23] HACK: Update Config.mk to pull all the right bits from my xenbits trees Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 0/9] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 1/9] xen_console: correctly cleanup primary console on teardown Ian Campbell
2015-10-22 16:46 ` Stefano Stabellini
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 2/9] xen: Switch to libxenevtchn interface for compat shims Ian Campbell
2015-10-23 11:06 ` Stefano Stabellini
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab " Ian Campbell
2015-10-23 11:06 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1510221754220.15801@kaball.uk.xensource.com>
2015-10-23 11:15 ` Ian Campbell
2015-10-23 12:42 ` Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 4/9] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 5/9] xen: Switch uses of xc_map_foreign_pages " Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 6/9] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API Ian Campbell
2015-10-23 11:06 ` Stefano Stabellini
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 7/9] xen: Use stable library interfaces when they are available Ian Campbell
2015-10-23 11:31 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1510231214140.15801@kaball.uk.xensource.com>
2015-10-23 12:25 ` Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 8/9] xen: domainbuild: reopen libxenctrl interface after forking for domain watcher Ian Campbell
2015-10-21 15:23 ` [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder Ian Campbell
2015-10-22 11:07 ` Ian Campbell
2015-10-23 11:12 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1510231209070.15801@kaball.uk.xensource.com>
2015-10-23 11:19 ` Ian Campbell
[not found] ` <1445599197.2374.127.camel@citrix.com>
2015-10-23 11:35 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1510231235120.15801@kaball.uk.xensource.com>
2015-10-23 12:23 ` Ian Campbell
[not found] ` <1445441038-25903-5-git-send-email-ian.campbell@citrix.com>
2015-10-23 11:07 ` [PATCH QEMU-XEN v4 4/9] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk Stefano Stabellini
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 1/5] qemu-xen-traditional: Use xentoollog as a separate library Ian Campbell
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 2/5] qemu-xen-traditional: Use libxenevtchn Ian Campbell
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 3/5] qemu-xen-traditional: Use libxengnttab Ian Campbell
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 4/5] qemu-xen-traditional: Add libxencall to rpath-link Ian Campbell
2015-10-21 15:24 ` [PATCH QEMU-XEN-TRADITIONAL v4 5/5] qemu-xen-traditional: Add libxenforeignmemory " Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 1/5] mini-os: Include libxentoollog with libxc Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 2/5] mini-os: Include libxenevtchn " Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 3/5] mini-os: Include libxengnttab " Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 4/5] mini-os: Include libxencall " Ian Campbell
2015-10-21 15:24 ` [PATCH MINI-OS v4 5/5] mini-os: Include libxenforeignmemory " Ian Campbell
2015-10-22 20:42 ` [PATCH MINI-OS v4 0/5] Begin to disentangle libxenctrl and provide some stable libraries Samuel Thibault
2015-10-23 9:43 ` Ian Campbell
2015-10-26 14:43 ` Wei Liu
2015-10-21 15:47 ` [Minios-devel] [PATCH v4 0/<VARIOUS>] " Ian Campbell
2015-11-09 12:02 ` Ian Campbell
2015-11-19 16:20 ` Stefano Stabellini
2015-11-19 17:01 ` Ian Campbell
2015-11-20 11:07 ` Stefano Stabellini
2015-11-20 11:24 ` Ian Campbell
2015-11-20 14:11 ` Stefano Stabellini
2015-11-20 11:38 ` Ian Campbell
2015-11-20 11:40 ` Ian Campbell
2015-11-20 13:49 ` Stefano Stabellini
2015-11-23 12:49 ` Ian Campbell
2015-12-03 9:44 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445441010-25776-16-git-send-email-ian.campbell@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).