From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Wei.Liu2@citrix.com
Subject: Re: [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof
Date: Fri, 23 Oct 2015 14:30:59 +0100 [thread overview]
Message-ID: <1445607059.2374.165.camel@citrix.com> (raw)
In-Reply-To: <562A3295.6010901@citrix.com>
On Fri, 2015-10-23 at 14:13 +0100, Julien Grall wrote:
> Hi,
>
> On 04/10/15 20:24, Julien Grall wrote:
> > The keyword typeof is not portable:
> >
> > /usr/src/freebsd/sys/xen/hypervisor.h:93:2: error: implicit declaration
> > of function 'typeof' is invalid in C99
> > [-Werror,-Wimplicit-function-declaration]
>
> Ping? Aside the fact that other bits of the header may not be iso
> compliant, I still think this patch is valid.
Yes, I agree.
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Jan, after your earlier comments are you happy to go ahead with this for
now and sort the other possible issues separately?
>
> FWIW, it fixed build of the FreeBSD kernel for ARM64 with Xen enabled.
>
> Regards,
>
next prev parent reply other threads:[~2015-10-23 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-04 19:24 [PATCH for-4.6] xen/public: arm: Use __typeof__ rather than typeof Julien Grall
2015-10-05 10:31 ` Jan Beulich
2015-10-06 17:25 ` Julien Grall
2015-10-07 6:31 ` Jan Beulich
2015-10-07 8:28 ` Ian Campbell
2015-10-05 13:40 ` Wei Liu
2015-10-06 9:43 ` Julien Grall
2015-10-23 13:13 ` Julien Grall
2015-10-23 13:30 ` Ian Campbell [this message]
2015-10-23 13:52 ` Jan Beulich
2015-10-23 13:58 ` Julien Grall
2015-10-23 14:16 ` Jan Beulich
2015-10-23 14:31 ` Ian Campbell
2015-10-23 14:35 ` Ian Campbell
2015-10-23 14:37 ` Jan Beulich
2015-10-23 14:44 ` Julien Grall
2015-10-23 14:55 ` Ian Campbell
2015-10-23 15:11 ` Jan Beulich
2015-10-26 18:08 ` Julien Grall
2015-10-27 8:05 ` Jan Beulich
2015-10-28 15:44 ` Julien Grall
2015-10-28 15:52 ` Jan Beulich
2015-10-29 11:40 ` Stefano Stabellini
2015-10-27 8:07 ` Jan Beulich
2015-10-27 10:20 ` Julien Grall
2015-10-23 14:03 ` Ian Campbell
2015-10-23 14:24 ` Jan Beulich
2015-10-23 14:48 ` Ian Campbell
2015-10-23 14:55 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445607059.2374.165.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Wei.Liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).