From: Ian Campbell <ian.campbell@citrix.com>
To: Zhigang Wang <zhigang.x.wang@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] tools/python: remove broken xl binding
Date: Fri, 23 Oct 2015 14:51:49 +0100 [thread overview]
Message-ID: <1445608309.2374.177.camel@citrix.com> (raw)
In-Reply-To: <5616958B.6060308@oracle.com>
On Thu, 2015-10-08 at 12:10 -0400, Zhigang Wang wrote:
> On 10/08/2015 11:28 AM, Ian Campbell wrote:
> > On Thu, 2015-10-08 at 10:58 -0400, Zhigang Wang wrote:
> > > On 10/08/2015 10:40 AM, Ian Campbell wrote:
> > > > On Tue, 2015-10-06 at 15:09 -0400, Konrad Rzeszutek Wilk wrote:
> > > > > On Tue, Oct 06, 2015 at 06:13:04PM +0100, Andrew Cooper wrote:
> > > > > > On 06/10/15 17:57, Wei Liu wrote:
> > > > > > > Various people say this binding doesn't compile or doesn't
> > > > > > > work.
> > > > > > > Remove
> > > > > > > it for the benefit of xl feature development -- so that new
> > > > > > > features
> > > > > > > won't need to worry about making this broken binding happy.
> > > > > > >
> > > > > > > This isn't going to expose any user visible changes because
> > > > > > > that
> > > > > > > module
> > > > > > > is not built by default.
> > > > > > >
> > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > > > >
> > > > > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > > > >
> > > > > And Zhigang mentioned to me offline that he is OK with these
> > > > > being
> > > > > gone too.
> > > >
> > > > Could we get a formal ack from one of you then please?
> > >
> > > I'm OK with removing libxl python bindings.
> >
> > Thanks, are you okay with me translating this into
> >
> > Acked-by: Zhigang Wang <zhigang.x.wang@oracle.com>
> >
> > in the final commit?
>
> Yes.
>
> Acked-by: Zhigang Wang <zhigang.x.wang@oracle.com>
Thanks, acked it myself and applied.
next prev parent reply other threads:[~2015-10-23 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 16:57 [PATCH] tools/python: remove broken xl binding Wei Liu
2015-10-06 17:13 ` Andrew Cooper
2015-10-06 19:09 ` Konrad Rzeszutek Wilk
2015-10-08 14:40 ` Ian Campbell
2015-10-08 14:58 ` Zhigang Wang
2015-10-08 15:28 ` Ian Campbell
2015-10-08 16:10 ` Zhigang Wang
2015-10-23 13:51 ` Ian Campbell [this message]
2015-10-06 18:06 ` Konrad Rzeszutek Wilk
2015-10-06 18:09 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445608309.2374.177.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zhigang.x.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).