From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] tools/python: remove broken xl binding
Date: Fri, 23 Oct 2015 14:51:49 +0100
Message-ID: <1445608309.2374.177.camel@citrix.com>
References: <1444150646-7959-1-git-send-email-wei.liu2@citrix.com>
	<56140120.1090904@citrix.com> <20151006190922.GB13546@l.oracle.com>
	<1444315213.1410.212.camel@citrix.com> <5616848D.9030605@oracle.com>
	<1444318128.1410.244.camel@citrix.com> <5616958B.6060308@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7311588c8=Ian.Campbell@citrix.com>)
	id 1Zpcl7-0006FN-Uk
	for xen-devel@lists.xenproject.org; Fri, 23 Oct 2015 13:51:54 +0000
In-Reply-To: <5616958B.6060308@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Zhigang Wang <zhigang.x.wang@oracle.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-10-08 at 12:10 -0400, Zhigang Wang wrote:
> On 10/08/2015 11:28 AM, Ian Campbell wrote:
> > On Thu, 2015-10-08 at 10:58 -0400, Zhigang Wang wrote:
> > > On 10/08/2015 10:40 AM, Ian Campbell wrote:
> > > > On Tue, 2015-10-06 at 15:09 -0400, Konrad Rzeszutek Wilk wrote:
> > > > > On Tue, Oct 06, 2015 at 06:13:04PM +0100, Andrew Cooper wrote:
> > > > > > On 06/10/15 17:57, Wei Liu wrote:
> > > > > > > Various people say this binding doesn't compile or doesn't
> > > > > > > work.
> > > > > > > Remove
> > > > > > > it for the benefit of xl feature development -- so that new
> > > > > > > features
> > > > > > > won't need to worry about making this broken binding happy.
> > > > > > > 
> > > > > > > This isn't going to expose any user visible changes because
> > > > > > > that
> > > > > > > module
> > > > > > > is not built by default.
> > > > > > > 
> > > > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > > > > 
> > > > > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > > > > 
> > > > > And Zhigang mentioned to me offline that he is OK with these
> > > > > being
> > > > > gone too.
> > > > 
> > > > Could we get a formal ack from one of you then please?
> > > 
> > > I'm OK with removing libxl python bindings.
> > 
> > Thanks, are you okay with me translating this into
> > 
> > Acked-by: Zhigang Wang <zhigang.x.wang@oracle.com>
> > 
> > in the final commit?
> 
> Yes.
> 
> Acked-by: Zhigang Wang <zhigang.x.wang@oracle.com>

Thanks, acked it myself and applied.