Re: [PATCH v2 1/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE]

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1723 bytes --]

On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote:
> turning main function xl exit codes towards using the
> EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary
> numbers
> or libxl return codes.
> 
I'd say "turning xl main() function exit codes..."

Also in the subject "xl: convert main() exit codes to..."

> also includes a document comment in xl.h stating xl process should
> always return EXIT_FOO and main_* can be treated as main() as if
> they are returning a process exit status and not a function return
> value)
> 
> Signed-off-by: Harmandeep Kaur <write.harmandeep@gmail.com>
>
I also have a (minor) comment to the code but, with the subject,
changelog, and comment (see below) fixed, this patch can have:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

> --- a/tools/libxl/xl.h
> +++ b/tools/libxl/xl.h
> @@ -30,6 +30,12 @@ struct cmd_spec {
>      char *cmd_option;
>  };
>  
> +/*
> +*xl process should always return EXIT_FOO and main_* can be treated
> +*as main() as if they are returning a process exit status and not a
> +*function return value.
> +*/
> +
I think it is important to be a bit more precise, here. After all,
we're explaining people how they should do things, so let's do it
properly. :-)

"The xl process should always return either EXIT_SUCCESS or
EXIT_FAILURE. main_* functions, implementing the various xl commands,
can be treated..."

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel