From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 1/5] xl: convert exit codes to EXIT_[SUCCESS|FAILURE] Date: Mon, 26 Oct 2015 10:32:03 +0100 Message-ID: <1445851923.2717.21.camel@citrix.com> References: <1445664696-14258-1-git-send-email-write.harmandeep@gmail.com> <1445664696-14258-2-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7900697658589004948==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zqe8v-0003oC-B0 for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 09:32:41 +0000 In-Reply-To: <1445664696-14258-2-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: lars.kurth@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com List-Id: xen-devel@lists.xenproject.org --===============7900697658589004948== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-HDuAA7ZnjZmDxLCOWwLN" --=-HDuAA7ZnjZmDxLCOWwLN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote: > turning main function xl exit codes towards using the > EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary > numbers > or libxl return codes. >=20 I'd say "turning xl main() function exit codes..." Also in the subject "xl: convert main() exit codes to..." > also includes a document comment in xl.h stating xl process should > always return EXIT_FOO and main_* can be treated as main() as if > they are returning a process exit status and not a function return > value) >=20 > Signed-off-by: Harmandeep Kaur > I also have a (minor) comment to the code but, with the subject, changelog, and comment (see below) fixed, this patch can have: Reviewed-by: Dario Faggioli > --- a/tools/libxl/xl.h > +++ b/tools/libxl/xl.h > @@ -30,6 +30,12 @@ struct cmd_spec { > char *cmd_option; > }; > =20 > +/* > +*xl process should always return EXIT_FOO and main_* can be treated > +*as main() as if they are returning a process exit status and not a > +*function return value. > +*/ > + I think it is important to be a bit more precise, here. After all, we're explaining people how they should do things, so let's do it properly. :-) "The xl process should always return either EXIT_SUCCESS or EXIT_FAILURE. main_* functions, implementing the various xl commands, can be treated..." Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-HDuAA7ZnjZmDxLCOWwLN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYt8xMACgkQk4XaBE3IOsSiSACffIgpXbGhDCljWKd9OFyLcOpC VYgAoJX6JePNljPirqUgBhfB3Q8hA88f =L9aA -----END PGP SIGNATURE----- --=-HDuAA7ZnjZmDxLCOWwLN-- --===============7900697658589004948== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7900697658589004948==--