From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2 3/5] xl: improve return and exit codes of
 vcpu related functions
Date: Mon, 26 Oct 2015 11:03:12 +0100
Message-ID: <1445853792.2717.38.camel@citrix.com>
References: <1445664696-14258-1-git-send-email-write.harmandeep@gmail.com>
	<1445664696-14258-4-git-send-email-write.harmandeep@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2050019547576001360=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7343f1c09=dario.faggioli@citrix.com>)
	id 1Zqeci-0005JL-8A
	for xen-devel@lists.xenproject.org; Mon, 26 Oct 2015 10:03:28 +0000
In-Reply-To: <1445664696-14258-4-git-send-email-write.harmandeep@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Harmandeep Kaur <write.harmandeep@gmail.com>, xen-devel@lists.xenproject.org
Cc: lars.kurth@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com
List-Id: xen-devel@lists.xenproject.org

--===============2050019547576001360==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-t8NMPkj8X04vF7ZiMJSJ"

--=-t8NMPkj8X04vF7ZiMJSJ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2015-10-24 at 11:01 +0530, Harmandeep Kaur wrote:
> turning vcpu manipulation functions xl exit codes toward using the
> EXIT_[SUCCESS|FAILURE] macros, instead of instead of arbitrary
> numbers
> or libxl return codes.
>=20
Again, distch "xl" from the sentence above.

Again, just one small comment:

> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c

> @@ -5508,7 +5506,9 @@ int main_vcpuset(int argc, char **argv)
>          break;
>      }
> =20
> -    return vcpuset(find_domain(argv[optind]), argv[optind + 1],
> check_host);
> +    if (vcpuset(find_domain(argv[optind]), argv[optind + 1],
> check_host))
> +        return EXIT_FAILURE;
> +    else return EXIT_SUCCESS;
>
There's no need of this 'else'.

With these things fixed, this patch is:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-t8NMPkj8X04vF7ZiMJSJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYt+mAACgkQk4XaBE3IOsQ/iQCbBjtVmpndsHlR8EOu7bZsHy6V
xFoAoI90ysUD0MSaLfzJFt990xP+qT+H
=RDdE
-----END PGP SIGNATURE-----

--=-t8NMPkj8X04vF7ZiMJSJ--


--===============2050019547576001360==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2050019547576001360==--