Re: [PATCH v3 1/5] xl: convert main() exit codes to EXIT_[SUCCESS|FAILURE]

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1158 bytes --]

On Tue, 2015-10-27 at 11:11 +0000, Wei Liu wrote:
> On Tue, Oct 27, 2015 at 03:20:48PM +0530, Harmandeep Kaur wrote:
> [...]
> >  };
> >  
> > +/*
> > + *The xl process should always return either EXIT_SUCCESS or
> > + *EXIT_FAILURE. main_* functions, implementing the various xl
> > + *commands, can be treated as main() as if they are returning
> > + *a process exit status and not a function return value.
> > + */
> > +
> 
> Missing spaces after "*". E.g.
>    /*
>     * The xl process ....
>     * EXIT_FAILURE
>     * ...
>     */
> 
> With that fixed:
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>
> 
> (This means after fixing the minor problem you can put the above tag
> in
> your commit message. If in doubt, please ask.)
> 
And, for what is worth, this one as well:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel