From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3 1/5] xl: convert main() exit codes to
 EXIT_[SUCCESS|FAILURE]
Date: Tue, 27 Oct 2015 12:20:20 +0100
Message-ID: <1445944820.2937.103.camel@citrix.com>
References: <1445939452-8091-1-git-send-email-write.harmandeep@gmail.com>
	<1445939452-8091-2-git-send-email-write.harmandeep@gmail.com>
	<20151027111109.GS18674@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6983839144875941208=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=73556bc40=dario.faggioli@citrix.com>)
	id 1Zr2Ir-0003lr-DS
	for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 11:20:33 +0000
In-Reply-To: <20151027111109.GS18674@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Harmandeep Kaur <write.harmandeep@gmail.com>
Cc: lars.kurth@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

--===============6983839144875941208==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-cbUwy1SKdHSVJSBU7DbE"

--=-cbUwy1SKdHSVJSBU7DbE
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2015-10-27 at 11:11 +0000, Wei Liu wrote:
> On Tue, Oct 27, 2015 at 03:20:48PM +0530, Harmandeep Kaur wrote:
> [...]
> >  };
> > =20
> > +/*
> > + *The xl process should always return either EXIT_SUCCESS or
> > + *EXIT_FAILURE. main_* functions, implementing the various xl
> > + *commands, can be treated as main() as if they are returning
> > + *a process exit status and not a function return value.
> > + */
> > +
>=20
> Missing spaces after "*". E.g.
>    /*
>     * The xl process ....
>     * EXIT_FAILURE
>     * ...
>     */
>=20
> With that fixed:
>=20
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>=20
> (This means after fixing the minor problem you can put the above tag
> in
> your commit message. If in doubt, please ask.)
>=20
And, for what is worth, this one as well:

Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-cbUwy1SKdHSVJSBU7DbE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYvXfQACgkQk4XaBE3IOsRDBgCcDtCIy5TqVNQKHFxT7Dnafp++
cpsAoImYwJiTqClyHRfDx84HgCNymdKI
=TdT8
-----END PGP SIGNATURE-----

--=-cbUwy1SKdHSVJSBU7DbE--


--===============6983839144875941208==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============6983839144875941208==--