From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v4 2/5] xl: improve return and exit codes of scheduling related functions Date: Tue, 27 Oct 2015 15:30:22 +0100 Message-ID: <1445956222.2937.155.camel@citrix.com> References: <1445950138-9908-1-git-send-email-write.harmandeep@gmail.com> <1445950138-9908-3-git-send-email-write.harmandeep@gmail.com> <20151027135032.GV18674@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0689446928218336395==" Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zr5Gf-0006kh-Jk for xen-devel@lists.xenproject.org; Tue, 27 Oct 2015 14:30:29 +0000 In-Reply-To: <20151027135032.GV18674@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Harmandeep Kaur Cc: lars.kurth@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, george.dunlap@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org --===============0689446928218336395== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-1wmEufI1Oi7gEwbT1q8o" --=-1wmEufI1Oi7gEwbT1q8o Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-10-27 at 13:50 +0000, Wei Liu wrote: > On Tue, Oct 27, 2015 at 06:18:55PM +0530, Harmandeep Kaur wrote: > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > index 646b281..b101aff 100644 > > --- a/tools/libxl/xl_cmdimpl.c > > +++ b/tools/libxl/xl_cmdimpl.c > > @@ -5793,18 +5793,15 @@ int main_sharing(int argc, char **argv) > > static int sched_domain_get(libxl_scheduler sched, int domid, > > libxl_domain_sched_params *scinfo) > > { > > - int rc; > > - > > - rc =3D libxl_domain_sched_params_get(ctx, domid, scinfo); > > - if (rc) { > > + if (libxl_domain_sched_params_get(ctx, domid, scinfo)){ >=20 > This, and other instances in both patch 2 and 3, violates coding > style. > You need to have a space before "{". >=20 Bha, I guess I was concentrating on the "return / exit()" changes, and managed to miss these! :-/ > After that, you can add my ack to all your patches. I haven't > carefully > read through every line of change, but I think Dario's review is > sufficient > and thorough.=20 > And yet, I managed to miss those coding style issues. :-( > Thanks Dario. >=20 Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-1wmEufI1Oi7gEwbT1q8o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYvin4ACgkQk4XaBE3IOsS2oQCeLwQB1GFmG8y2QweJRWIX6X0J 8dEAmwYco5JpzXI8cjg0BIaO1HmwG08g =u7LQ -----END PGP SIGNATURE----- --=-1wmEufI1Oi7gEwbT1q8o-- --===============0689446928218336395== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0689446928218336395==--