[PATCH v3] Leaking of xs_fd fixed in Xenstore

[PATCH v3] Leaking of xs_fd fixed in Xenstore

[Lasya]

The success path isn't closed xs_fd in build function in init-xenstore-domain.c . Added that line before return 0. 

Signed-off-by: Lasya Venneti <comethalley61@gmail.com>
---
 tools/xenstore/init-xenstore-domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/xenstore/init-xenstore-domain.c b/tools/xenstore/init-xenstore-domain.c
index 82ddabb..0397431 100644
--- a/tools/xenstore/init-xenstore-domain.c
+++ b/tools/xenstore/init-xenstore-domain.c
@@ -75,6 +75,7 @@ static int build(xc_interface *xch, int argc, char** argv)
 	rv = xc_domain_unpause(xch, domid);
 	if (rv) goto err;
 
+	close(xs_fd);
 	return 0;
 
 err:
-- 
1.9.1

Re: [PATCH v3] Leaking of xs_fd fixed in Xenstore

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 671 bytes --]

On Wed, 2015-10-28 at 05:43 +0530, Lasya wrote:
> The success path isn't closed xs_fd in build function in init
> -xenstore-domain.c . Added that line before return 0. 
> 
All that I said for the other patch, applies here too.

Also, the two patches are related. I think it would be good if you try
sending them as a patch series, rather than as two independent patches.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel