From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] dom variable error handled in Xenstore Date: Wed, 28 Oct 2015 02:00:47 +0100 Message-ID: <1445994047.2937.238.camel@citrix.com> References: <1445991143-9165-1-git-send-email-comethalley61@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4813826134573225535==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZrF71-0005Qq-PP for xen-devel@lists.xenproject.org; Wed, 28 Oct 2015 01:01:11 +0000 In-Reply-To: <1445991143-9165-1-git-send-email-comethalley61@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Lasya , xen-devel@lists.xenproject.org, george.dunlap@citrix.com, lars.kurth@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org --===============4813826134573225535== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-NHdD72M4bqe7R6amSHSW" --=-NHdD72M4bqe7R6amSHSW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-10-28 at 05:42 +0530, Lasya wrote: > xc_dom_allocate function in build function in init-xenstore-domain.c > returns NULL on failure.=20 > In that case, variable rv is set to ENOMEM and directed to failure > path err. =20 >=20 >=20 So, about the subject line: - we want tags (as in "tag: does some stuff"), in order to help people figure out quickly (and/or filter in their mail readers) what component of Xen the patch is about. In your case, a suitable tag would be "tools/xenstore:", or even just "xenstore:"; - it should hint at and summarize very very briefly what is being done. In this case, for instance, something like this: "xenstore: check for domain allocation errors". About the actual changelog: - wrap lines a bit more, ideally around 70 characters per line. The point being, it should display well in things like `git log', which typically indents it a bit; - it should describe what the patch does, at a higher abstraction level (e.g., why the patch is necessary, why a particular approach has been taken, etc.). What you have up here, can pretty much all be inferred already reading the code. So, for instance, something like this: "When building xenstore domain, failure at allocating the memory for it was not handled. Fix that" - since you are (I think) fixing an issue identified by Coverity, you should mention the Coverity ID in the changelog somehow as well. About the code: > Signed-off-by: Lasya Venneti > diff --git a/tools/xenstore/init-xenstore-domain.c=20 > @@ -42,6 +42,10 @@ static int build(xc_interface *xch, int argc, > char** argv) > snprintf(cmdline, 512, "--event %d --internal-db", rv); > =20 > dom =3D xc_dom_allocate(xch, cmdline, NULL); > + if (dom =3D=3D NULL) { > + rv =3D ENOMEM; > + goto err; > + } > On what basis did you decide that ENOMEM was a good return value? I mean, have you checked what kind of value / error code is being returned in the other cases (e.g., , xc_domain_setmaxmem(), xc_domain_max_vcpus(), etc), if something goes wrong? Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-NHdD72M4bqe7R6amSHSW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlYwHkAACgkQk4XaBE3IOsT6DACffgORpnPmDgOi2qRxNl8qg/DG Gj4AoJcDpHNPr/RdAWTWfy4cpS59VijW =RKFM -----END PGP SIGNATURE----- --=-NHdD72M4bqe7R6amSHSW-- --===============4813826134573225535== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4813826134573225535==--