From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] Leaking of xs_fd fixed in Xenstore Date: Wed, 28 Oct 2015 02:03:09 +0100 Message-ID: <1445994189.2937.241.camel@citrix.com> References: <1445991183-9208-1-git-send-email-comethalley61@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1913662315039734902==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZrF99-0007rS-06 for xen-devel@lists.xenproject.org; Wed, 28 Oct 2015 01:03:23 +0000 In-Reply-To: <1445991183-9208-1-git-send-email-comethalley61@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Lasya , xen-devel@lists.xenproject.org, george.dunlap@citrix.com, lars.kurth@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org --===============1913662315039734902== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-qFMWZjROaQTeesvfPsaZ" --=-qFMWZjROaQTeesvfPsaZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2015-10-28 at 05:43 +0530, Lasya wrote: > The success path isn't closed xs_fd in build function in init > -xenstore-domain.c . Added that line before return 0.=20 >=20 All that I said for the other patch, applies here too. Also, the two patches are related. I think it would be good if you try sending them as a patch series, rather than as two independent patches. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-qFMWZjROaQTeesvfPsaZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEUEABECAAYFAlYwHs0ACgkQk4XaBE3IOsQ3pwCgocbCjH9IA8HdgQ+tqerpaRqI /nIAl3XSjOcv8Pyuq8Kv/LRYKVe3BY4= =L6uG -----END PGP SIGNATURE----- --=-qFMWZjROaQTeesvfPsaZ-- --===============1913662315039734902== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============1913662315039734902==--