From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
Cc: Julien Grall <julien.grall@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP
Date: Tue, 3 Nov 2015 16:36:09 +0000 [thread overview]
Message-ID: <1446568569.16178.30.camel@citrix.com> (raw)
In-Reply-To: <562FB71902000078000AF499@prv-mh.provo.novell.com>
On Tue, 2015-10-27 at 10:40 -0600, Jan Beulich wrote:
> > > > On 27.10.15 at 17:32, <oleksandr.tyshchenko@globallogic.com> wrote:
> > And what are you suggesting about the patch? Create a separate OMAP
> > specific header?
>
> For #define-s used by only a single source file I'd suggest putting
> them into the source file instead of into a (shared) header.
I agree. (Any to be clear, any existing OMAP specific things in 8250,h
should move too).
Ian.
next prev parent reply other threads:[~2015-11-03 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 10:36 [PATCH v1] xen/serial: Return actual bytes stored in TX FIFO for OMAP Oleksandr Tyshchenko
2015-10-27 10:50 ` Jan Beulich
2015-10-27 10:54 ` Julien Grall
2015-10-27 11:05 ` Jan Beulich
2015-10-27 11:15 ` Julien Grall
2015-10-27 11:33 ` Oleksandr Tyshchenko
2015-10-27 16:32 ` Oleksandr Tyshchenko
2015-10-27 16:40 ` Jan Beulich
2015-11-03 16:36 ` Ian Campbell [this message]
2015-11-04 16:09 ` Oleksandr Tyshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446568569.16178.30.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@citrix.com \
--cc=oleksandr.tyshchenko@globallogic.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).