From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH v2 12/16] hvmloader: Load ACPI tables from hvm_start_info module Date: Wed, 4 Nov 2015 11:20:22 +0000 Message-ID: <1446636022.6461.64.camel@citrix.com> References: <1445875397-2846-1-git-send-email-anthony.perard@citrix.com> <1445875397-2846-13-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1445875397-2846-13-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Anthony PERARD , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-10-26 at 16:03 +0000, Anthony PERARD wrote: > ... and use it with both SeaBIOS and OVMF. > > This may change the behavior of guest using OVMF as the ACPI tables > currently loaded are the one for qemu-xen-traditionnal. "traditional". I'm a bit surprised using the trad ones works, given OVMF is always associated with qemu-xen. I'm inclined to suggest that this bugfix should be split out and committed sooner rather than later, independently of this series. Apart from cleanly separating out a potentially interesting change it also gives us a longer runway for testing it doesn't knacker anything.