From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 3/9] xen/arm: vgic: Properly emulate the full register Date: Mon, 16 Nov 2015 13:29:09 +0000 Message-ID: <1447680549.27871.90.camel@citrix.com> References: <1447415672-31633-1-git-send-email-julien.grall@citrix.com> <1447415672-31633-4-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZyJqi-0000dm-QT for xen-devel@lists.xenproject.org; Mon, 16 Nov 2015 13:29:41 +0000 In-Reply-To: <1447415672-31633-4-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-11-13 at 11:54 +0000, Julien Grall wrote: > The offset in the emulation is based on byte. As most of the registers > are 64/32 bits, they will span over multiple bytes. > > However, the current emulation only care about the first offset. This "cares" > will result to not emulate properly any access on the register with "This results in not properly emulating ... with any other offset" > other offset. > > Introduce new macros to help implementing access on multiple byte and > use them over the vGIC emulation. > > Note that I didn't convert the reserved/implementation defined > registers. It will be done in a follow-up. > > Signed-off-by: Julien Grall Acked-by: Ian Campbell