From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits
Date: Tue, 24 Nov 2015 16:51:51 +0000 [thread overview]
Message-ID: <1448383911.26412.62.camel@citrix.com> (raw)
In-Reply-To: <1447937169-21973-1-git-send-email-julien.grall@citrix.com>
On Thu, 2015-11-19 at 12:46 +0000, Julien Grall wrote:
> This is a follow of commit 90f2e2a307fc6a6258c39cc87b3b2bf9441c0fa7 "use
> masking operation instead of test_bit for MCSF bits" where the ARM
> changes were missing.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked + applied.
> ---
> xen/arch/arm/domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 880d0a6..1b0f9eb 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -327,7 +327,7 @@ void hypercall_cancel_continuation(void)
> struct cpu_user_regs *regs = guest_cpu_user_regs();
> struct mc_state *mcs = ¤t->mc_state;
>
> - if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
> + if ( mcs->flags & MCSF_in_multicall )
> {
> __clear_bit(_MCSF_call_preempted, &mcs->flags);
> }
> @@ -352,7 +352,7 @@ unsigned long hypercall_create_continuation(
>
> va_start(args, format);
>
> - if ( test_bit(_MCSF_in_multicall, &mcs->flags) )
> + if ( mcs->flags & MCSF_in_multicall )
> {
> __set_bit(_MCSF_call_preempted, &mcs->flags);
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-11-24 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 12:46 [PATCH] xen/arm: use masking operation instead of test_bit for MCSF bits Julien Grall
2015-11-24 16:51 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448383911.26412.62.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).