Re: [PATCH v3 4/6] xl: Return an error on failed cd-insert

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-12-01 at 11:53 +0000, George Dunlap wrote:
> This makes xl more useful in scripts.
> 
> The strange thing about this is that the internal cd_insert function
> *already* returned something appropriate, and cd-eject was using it,
> but cd-insert wasnt.

Missing an apostrophe in wasnt.

> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>

Acked-by: Ian Campbell <Ian.campbell@citrix.com>

> ---
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Ian Jackson <ian.jackson@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 4455d73..72ece2e 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -3405,8 +3405,7 @@ int main_cd_insert(int argc, char **argv)
>      virtdev = argv[optind + 1];
>      file = argv[optind + 2];
>  
> -    cd_insert(domid, virtdev, file);
> -    return 0;
> +    return cd_insert(domid, virtdev, file);
>  }
>  
>  int main_console(int argc, char **argv)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel