From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: [PATCH RFC XEN v1 14/14] tools/libxl: BODGE ARM save/restore and (dead) migration. Date: Wed, 9 Dec 2015 14:32:28 +0000 Message-ID: <1449671548-4050-14-git-send-email-ian.campbell@citrix.com> References: <1449671507.16124.264.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449671507.16124.264.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com, julien.grall@citrix.com Cc: andrew.cooper3@citrix.com, Ian Campbell List-Id: xen-devel@lists.xenproject.org *** NOT TO BE APPLIED *** Currently no support (even in this series) for live migration so removing LIBXL_HAVE_NO_SUSPEND_RESUME on ARM for real seems premature. This bodge however lets xl save/restore work and causes xl migrate to do a dead instead of live migration for testing. Do not apply this nonsense. --- tools/libxl/libxl.h | 3 ++- tools/libxl/xl_cmdimpl.c | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h index 6b73848..5516bbb 100644 --- a/tools/libxl/libxl.h +++ b/tools/libxl/libxl.h @@ -677,7 +677,8 @@ typedef struct libxl__ctx libxl_ctx; * - libxl_domain_remus_start */ #if defined(__arm__) || defined(__aarch64__) -#define LIBXL_HAVE_NO_SUSPEND_RESUME 1 +/* XXX have suspend/resume, but not live migration */ +//#define LIBXL_HAVE_NO_SUSPEND_RESUME 1 #endif /* diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 2b6371d..7104872 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -4291,7 +4291,13 @@ static void migrate_domain(uint32_t domid, const char *rune, int debug, char *away_domname; char rc_buf; uint8_t *config_data; - int config_len, flags = LIBXL_SUSPEND_LIVE; + int config_len, flags = +#if defined(__arm__) || defined(__aarch64__) + 0 +#else + LIBXL_SUSPEND_LIVE +#endif + ; save_domain_core_begin(domid, override_config_file, &config_data, &config_len); -- 2.6.1