From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 8/9] xenstore: write xenstore domain data to xenstore Date: Tue, 15 Dec 2015 12:49:21 +0000 Message-ID: <1450183761.16856.173.camel@citrix.com> References: <1449848861-7700-1-git-send-email-jgross@suse.com> <1449848861-7700-9-git-send-email-jgross@suse.com> <1450182380.16856.159.camel@citrix.com> <567008E2.9090606@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <567008E2.9090606@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Juergen Gross , xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-12-15 at 13:34 +0100, Juergen Gross wrote: > On 15/12/15 13:26, Ian Campbell wrote: > > On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote: > > > After starting the xenstore domain write the basic data (domid and > > > name) to the xenstore. > > > > > > Add a new option to init-xenstore-domain to be able to specify the > > > domain's name. > > > > Is all this enough to keep "xl list" etc happy? > > I hope so. At least I didn't notice any problems. Great. Please could you add "This makes the domain appear correctly in xl list" or something similar. > > Do we need to also create a dummy json object like we do for dom0 > > (init- > > xen-dom0)? > > Good question. Depends on what the dom0 json object is used for. Mostly for various types of hotplug (irrelevant here I guess?) and reboot (also irrelevant?). Maybe also "xl list -v" or some other "look more closely" xl commands? mem-set too perhaps? Ian. > BTW: I think I've found another detail missing: > tools/hotplug/Linux/xendomains.in might need a tweak to avoid stopping > the xenstore domain. > > > Juergen