From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH RFC XEN v1 08/14] xen: arm: Save and restore
 arch timer state.
Date: Wed, 16 Dec 2015 16:37:43 +0000
Message-ID: <1450283863.4053.68.camel@citrix.com>
References: <1449671507.16124.264.camel@citrix.com>
	<1449671548-4050-8-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1512161510070.17516@kaball.uk.xensource.com>
	<1450281756.4053.65.camel@citrix.com> <56718EB6.9050407@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56718EB6.9050407@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: wei.liu2@citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-12-16 at 16:17 +0000, Julien Grall wrote:
> Hi,
> 
> On 16/12/15 16:02, Ian Campbell wrote:
> > The PPI state is saved by the GIC. Perhaps we should save the actual
> > number
> > used by the guest here though.
> 
> I think we have to save the actual number as we don't guarantee that the
> interrupt (and memory layout BTW) for the guest won't change between 2
> versions of Xen.

Yes. As with other things which are saved here that are currently platform
constants the restore side will become a check against the hardcoded number
for now (i.e. no compat code until it becomes needed),

Ian.