From: Jonathan Creekmore <jonathan.creekmore@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Jonathan Creekmore <jonathan.creekmore@gmail.com>,
Dario Faggioli <dario.faggioli@citrix.com>
Subject: [PATCH 4/4] sched: Use the auto-generated list of schedulers
Date: Thu, 17 Dec 2015 14:59:34 -0600 [thread overview]
Message-ID: <1450385974-12732-5-git-send-email-jonathan.creekmore@gmail.com> (raw)
In-Reply-To: <1450385974-12732-1-git-send-email-jonathan.creekmore@gmail.com>
Instead of having a manually-curated list of schedulers, use the array
that was auto-generated simply by compiling in the scheduler files as
the sole source of truth of the available schedulers.
CC: George Dunlap <george.dunlap@eu.citrix.com>
CC: Dario Faggioli <dario.faggioli@citrix.com>
Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
---
xen/common/schedule.c | 24 +++++++-----------------
xen/include/xen/sched-if.h | 5 -----
2 files changed, 7 insertions(+), 22 deletions(-)
diff --git a/xen/common/schedule.c b/xen/common/schedule.c
index 2f98a48..efbd67d 100644
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -64,20 +64,10 @@ static void poll_timer_fn(void *data);
DEFINE_PER_CPU(struct schedule_data, schedule_data);
DEFINE_PER_CPU(struct scheduler *, scheduler);
-static const struct scheduler *schedulers[] = {
-#ifdef CONFIG_SCHED_CREDIT
- &sched_credit_def,
-#endif
-#ifdef CONFIG_SCHED_CREDIT2
- &sched_credit2_def,
-#endif
-#ifdef CONFIG_SCHED_ARINC653
- &sched_arinc653_def,
-#endif
-#ifdef CONFIG_SCHED_RTDS
- &sched_rtds_def,
-#endif
-};
+extern const struct scheduler *__schedulers_start[], *__schedulers_end[];
+#define NUM_SCHEDULERS (((uintptr_t)__schedulers_end-(uintptr_t)__schedulers_start) \
+ / sizeof(struct scheduler *))
+static const struct scheduler **schedulers = __schedulers_start;
static struct scheduler __read_mostly ops;
@@ -1468,7 +1458,7 @@ void __init scheduler_init(void)
open_softirq(SCHEDULE_SOFTIRQ, schedule);
- for ( i = 0; i < ARRAY_SIZE(schedulers); i++ )
+ for ( i = 0; i < NUM_SCHEDULERS; i++)
{
if ( schedulers[i]->global_init && schedulers[i]->global_init() < 0 )
schedulers[i] = NULL;
@@ -1479,7 +1469,7 @@ void __init scheduler_init(void)
if ( !ops.name )
{
printk("Could not find scheduler: %s\n", opt_sched);
- for ( i = 0; i < ARRAY_SIZE(schedulers); i++ )
+ for ( i = 0; i < NUM_SCHEDULERS; i++ )
if ( schedulers[i] )
{
ops = *schedulers[i];
@@ -1599,7 +1589,7 @@ struct scheduler *scheduler_alloc(unsigned int sched_id, int *perr)
int i;
struct scheduler *sched;
- for ( i = 0; i < ARRAY_SIZE(schedulers); i++ )
+ for ( i = 0; i < NUM_SCHEDULERS; i++ )
if ( schedulers[i] && schedulers[i]->sched_id == sched_id )
goto found;
*perr = -ENOENT;
diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
index 9c6e0f5..66dc9c8 100644
--- a/xen/include/xen/sched-if.h
+++ b/xen/include/xen/sched-if.h
@@ -165,11 +165,6 @@ struct scheduler {
void (*tick_resume) (const struct scheduler *, unsigned int);
};
-extern const struct scheduler sched_credit_def;
-extern const struct scheduler sched_credit2_def;
-extern const struct scheduler sched_arinc653_def;
-extern const struct scheduler sched_rtds_def;
-
#define REGISTER_SCHEDULER(x) static const struct scheduler *x##_entry \
__used_section(".data.schedulers") = &x;
--
2.6.4
next prev parent reply other threads:[~2015-12-17 21:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 20:59 [PATCH 0/4] Allow schedulers to be selectable through Kconfig Jonathan Creekmore
2015-12-17 20:59 ` [PATCH 1/4] build: Hook the schedulers into Kconfig Jonathan Creekmore
2015-12-18 1:35 ` Dario Faggioli
2015-12-18 2:20 ` Jonathan Creekmore
2015-12-18 9:19 ` Dario Faggioli
2015-12-18 10:52 ` George Dunlap
2015-12-18 11:23 ` Dario Faggioli
2015-12-18 8:57 ` Andrew Cooper
2015-12-18 16:43 ` Jonathan Creekmore
2015-12-17 20:59 ` [PATCH 2/4] build: Alloc space for sched list in the link file Jonathan Creekmore
2015-12-18 9:01 ` Andrew Cooper
2015-12-18 16:40 ` Jonathan Creekmore
2015-12-18 16:48 ` Andrew Cooper
2015-12-18 17:07 ` Jan Beulich
2015-12-18 17:10 ` Andrew Cooper
2015-12-18 17:11 ` Jonathan Creekmore
2015-12-18 17:23 ` Andrew Cooper
2015-12-17 20:59 ` [PATCH 3/4] sched: Register the schedulers into the list Jonathan Creekmore
2015-12-18 1:42 ` Dario Faggioli
2015-12-18 9:03 ` Andrew Cooper
2015-12-17 20:59 ` Jonathan Creekmore [this message]
2015-12-18 1:47 ` [PATCH 4/4] sched: Use the auto-generated list of schedulers Dario Faggioli
2015-12-18 9:12 ` Andrew Cooper
2015-12-18 16:44 ` Jonathan Creekmore
2015-12-18 10:50 ` Jan Beulich
2015-12-18 16:00 ` Jonathan Creekmore
2015-12-18 16:43 ` Jan Beulich
2015-12-18 17:24 ` Jonathan Creekmore
2015-12-18 17:30 ` Andrew Cooper
2015-12-18 10:39 ` [PATCH 0/4] Allow schedulers to be selectable through Kconfig Jan Beulich
2015-12-18 10:45 ` Ian Campbell
2015-12-18 10:58 ` Jan Beulich
2015-12-18 11:08 ` Juergen Gross
2015-12-18 11:19 ` Ian Campbell
2015-12-18 11:30 ` Jan Beulich
[not found] ` <5673FC6202000078000C122B@suse.com>
2015-12-18 11:41 ` Juergen Gross
2015-12-18 17:56 ` Doug Goldstein
2015-12-18 18:25 ` Andrew Cooper
2016-01-06 14:45 ` Ian Campbell
2016-01-07 14:01 ` Jonathan Creekmore
2016-01-07 14:37 ` Jan Beulich
2016-01-07 15:00 ` Ian Campbell
2016-01-07 15:18 ` Doug Goldstein
2016-01-07 15:31 ` Ian Campbell
2016-01-07 15:43 ` Jonathan Creekmore
2016-01-07 15:54 ` Jan Beulich
2016-01-07 15:47 ` Jan Beulich
2016-01-07 15:30 ` Ian Campbell
2016-01-07 15:51 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450385974-12732-5-git-send-email-jonathan.creekmore@gmail.com \
--to=jonathan.creekmore@gmail.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).